fix(ux): P1 — tab bar label clipping + home greeting & AI entry - #104
Merged
Conversation
Tab bar: CJK labels were clipped at the bottom edge without a safe-area inset (web / no-home-indicator devices). Reserve a floor of bottom padding and pin the label lineHeight so descenders always clear the edge — the labels were collapsing to a 1px line otherwise. Home: replace the static "Dashboard / Welcome back" header with a time-of-day greeting + the signed-in user's first name, surface a prominent AI Assistant entry card (previously buried two levels deep under More), and group the dashboards under a section heading. All strings are i18n'd (en/zh/ar `home.*`). Verified in the browser: labels render full-height, greeting + AI card + grouped dashboards display in Chinese. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two P1 UX items from the mobile walkthrough.
Tab bar — CJK labels clipped
Without a bottom safe-area inset (web, or a device with no home indicator) the tab labels sat flush against the edge and were clipped; on web the label box collapsed to 1px tall (invisible). Fixed by reserving a floor of bottom padding (
max(inset, 12)), giving the bar an explicit height, and pinning the labellineHeightso descenders always clear the edge.Home — greeting + AI entry + grouping
The home screen showed a static English "Dashboard / Welcome back" header and listed only dashboards. Now:
晚上好, Flow).home.*added to en / zh / ar).Verified in the browser at mobile width (zh locale): greeting, AI card, grouped dashboards, and full-height tab labels all render correctly.
🤖 Generated with Claude Code