Skip to content

[finding] engine-hook-provenance-sibling-seams.test.ts still says the readonlyWhen seam is "WITHHELD pending a maintainer ruling" — it was ruled B, and PR #14690 adds a cross-reference that lands readers on the stale text #14693

Description

@os-musk

Found by the dev implementing #14259's seam-1 residual (PR #14690) and handed to this seat to file because every dedup channel was unreachable from its container at the time — MCP search_issues returned API rate limit already exceeded for user ID 323835826, repo-scoped REST is 403, gh is absent. Handing it over rather than opening a card without dedup is the correct fallback, and this seat has now run the dedup (positive control: #14259 returned first; no duplicate).

⛔ Not fixed in PR #14690: the ruling's execution note names only the docblock plus the two face pins, and the file is outside both that scope and the dev's declared surface.

The stale prose, measured on origin/main

Three lines, in two regions of packages/objectql/src/engine-hook-provenance-sibling-seams.test.ts:

:23   // WITHHELD pending a maintainer ruling, not forgotten. Measured on this branch:
:30   // predicate — and it goes to the decision inbox, never resolved here.
:352  //   to the decision inbox; nothing here resolves it.

Control on the same file: MEASURED returns 1, so the zero-risk half of this reading is real rather than a broken path.

⚠️ Note the dev reported "two places" and named :338; the precise reading on today's main is three lines and the third sits at :352. Re-measure before editing — PR #14690 and PR #14665 may both have landed by then and the numbers will move.

Why it matters now rather than whenever

All three were true when written. Decision batch #12 item 4 has since ruled B on exactly that question (recorded on #14259 as comment 5511947941, maintainer verbatim 「同意」): seam 1 stays on value equality, a self-assigning hook does not unlock a readonlyWhen state lock, and the asymmetry with the static face is deliberate and now written down.

⭐ The reason this is worth a card rather than drift: PR #14690 adds a cross-reference pointing here. Its two new comment blocks link the three faces so they read side by side — which means a reader who follows that link now arrives at text telling them the matter is undecided and headed for the decision inbox. The PR that documents the ruling routes readers into the sentence that contradicts it.

Suggested shape — comment-only

Replace the three passages with a pointer to the recorded asymmetry (the corrected isCallerSuppliedValue docblock and the two face pins PR #14690 lands), keeping every assertion in the file untouched. Same defect class as #14259 itself: prose that was accurate when written and that a later ruling falsified.

Dedup

Semantic query with a live-channel positive control (#14259 returned). No open card covers this file's prose. Distinguished from #14678 (residual bare 'global' literals in action-execution.ts) and #14680 (the metadata root-entry import footprint) — different files, different subjects.

Unassigned, recording only.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions