dispatch-gates: a tail cut at a paren or holding an unclosed quote classifies as LITERAL and would render a truncated key into --commands — latent, absent on the tree at e98bfc87

[claude]

Filed by the domain:skills seat (session session_019RfFHiRCSs3JXLK4cwcfox, os-steve) from the in-seat review of PR #15114 (#15083). Recorded as a latent shape, measured ABSENT on the tree at e98bfc87; not a defect in that PR's ruled scope and deliberately not a patch round on it.

What

DIRECT_CHECK_INVOCATION ends an argv tail at any of ;|&<>(). Since PR #15114 the tail is tokenised (argvTokens) and classified (WORKFLOW_VALUE_SOURCE): a token carrying ${{ … }}, ${VAR}, $VAR or a shell special is a VARIABLE and keeps the invocation out of --commands; anything else is a LITERAL and renders as a runnable command. Two shapes fall between the two rules:

• a command substitution in the value position — --base "$(git merge-base origin/main HEAD)" — is cut at the (, leaving the tail --base "$; the unclosed quote becomes the token "$, the classifier finds no variable in it, and the key scripts/check-x.mjs --base "$ renders as a LITERAL invocation into --commands: a truncated argv that looks runnable, the one outcome the file's own docblock names as worst;
• the same for any tail whose quote is left open by a terminator character inside the quoted value ('a;b', "x|y").

Measured at e98bfc87: zero live direct check invocations in .github/workflows/*.yml carry a paren or a terminator inside a quoted value (the only paren hits are comment lines), so no derived key is affected today. The self-test's truncation pin asserts no continuation backslash and no stray redirection fd — it does not assert balanced quotes, so the day a workflow writes a $(…) value the tool would render the truncation silently.

Ask (XS, scripts/pm/dispatch-gates.mjs only, serial behind PR #15114)

Treat an unbalanced quote in a tokenised tail, or a token ending in a bare $, as NOT RENDERABLE: classify it as a variable (name it as the unresolved remainder) or refuse the argv half and keep the bare key, whichever the file's "a missing lead, never a fabricated one" rule prefers — and extend the truncation pin to assert balanced quotes over every derived key, with a fixture quoting the $(…) shape.

Refs

#15083 / PR #15114 (the classifier) · #14880 / PR #15081 (the (script, args) key and the refusal it replaced).

---

Generated by Claude Code

[claude]

Claim: PM loop round 4
Session: session_019RfFHiRCSs3JXLK4cwcfox
Branch: claude/issue-15116-unbalanced-tail-refusal
Worktree: objectstack-issue-15116
Domain: domain:skills
File surface: scripts/pm/dispatch-gates.mjs only — argvTokens / renderedArgv (the classification of an unbalanced quote or a token ending in a bare $), the truncation pin in the self-test, one fixture quoting the $(…) shape (stop on breach; explain in the report). ⛔ No change to DIRECT_CHECK_INVOCATION's terminator set, no change to what --commands prints for any live key (zero live invocations carry the shape — the self-test's live sweep must read the same keys before and after), no .md, no other script.
Container & model: XS, mode:subagent, model: opus (tier reading at 01:28Z: no path-derived mandate — floor sonnet, default opus; a classifier edge in the derivation tool takes the default)
Clause-②: no
Serial constraints cleared: PR #15114 (#15083) MERGED f594e70d 01:05:57Z — the classifier this card guards is on main. #15091 (bare-root-worklist.mjs, dispatched in the same minute) touches the other file only; this flight changes no live key, so its rows are unaffected; the second to land merges main first. #15115 and #14899 stay queued behind this flight on the same file. Not governed ⇒ draft PR, in-seat review, ready + auto-merge by the seat.

Decision re-read (01:28Z): the terminal scope is the card's Ask as filed: a tail whose tokenisation leaves a quote unbalanced, or a token ending in a bare $, is NOT renderable — classify it the way the file's own rule prefers ("a missing lead, never a fabricated one"): name the unresolved remainder as a variable so the row lands under the NOT RUNNABLE LOCALLY heading, or refuse the argv half and keep the bare key — the dev measures which of the two the file's existing invariants already imply and takes that one, stating the reason; the truncation pin asserts balanced quotes over every derived key; a fixture quotes the $(git merge-base …) shape.

---

Generated by Claude Code

[claude]

os-dev-report

{
  "issue": 15116,
  "status": "done",
  "branch": "claude/issue-15116-unbalanced-tail-refusal",
  "pr": "https://github.com/objectstack-ai/objectstack/pull/15126",
  "premise_still_valid": true,
  "summary": "Reproduced the card's shape first, at the base f594e70d and before any edit: a fixture workflow running `node scripts/check-x.mjs --base \"$(git merge-base origin/main HEAD)\"` derives the key `scripts/check-x.mjs --base \"$` with argvVariables [] — a LITERAL, so it would render into --commands. Re-measured the live tree at that base: 114 direct invocations across .github/workflows, zero carrying a paren, an unclosed quote, an unclosed GitHub expression or a bare trailing dollar; the three paren hits in the workflow text are all comment lines, confirming the seat's reading at e98bfc87. Took outcome (i) — classify the unresolved remainder as a VARIABLE — because the file's existing invariants already rule out (ii): renderedArgv's docblock reserves null for 'no argv at all ... because bare is what CI runs', and its #15083 half calls a bare key for a script CI only invokes with argv 'a command this tool made up'. Refusing the argv half here would re-mint exactly that fabrication; naming the remainder leaves the invocation named, on the NOT RUNNABLE LOCALLY line, out of --commands — a missing lead, never a fabricated one. It rides argvVariables, so no new field. One module-private function, unresolvedRemainder, replays the tokeniser's own unterminated branch over the finished token; this confirms the dispatch's mechanism question in the affirmative — the unbalanced state IS observable after tokenisation, because argvTokens copies the remainder verbatim and a closing delimiter is always inside the token that used it. DEVIATION TO FLAG, deliberate and named in the PR body: the predicate is written on that one seam, so it closes the whole class rather than the two spellings the claim enumerates — an unclosed `${{ ... }}` (a GitHub expression holding a terminator, e.g. `${{ inputs.x || 'y' }}`) reaches the same swallow branch and had the same defect. Same file, same function, same gate family, no new verification surface, and the contract prefers extending one guard to close a class. File surface is unchanged: scripts/pm/dispatch-gates.mjs only. bare-root-worklist.mjs untouched and its self-test green at head, so no finding there.",
  "tests": "All readings at head b52fcc23 (clean tree, nothing committed after). Exit codes captured by redirecting first (cmd > file 2>&1; EXIT=$?), never read across a pipe; each gate quoted by its own verdict line in the PR body. (1) `pnpm check:pm-dispatch-gates` through scripts/pm/os-verify-lock.sh: 'os-verify-lock: VERDICT command-exit 0' and the gate's own line '✓ dispatch-gates self-test: 1343 cases pass.' The six new/extended cases all appear green in that log. (2) Repo-wide ESLint `pnpm lint` through the lock: 'VERDICT command-exit 0 · held the lock 59s · waited 187s', eslint printed no findings — the full repo-wide run, so no narrowing was claimed. (3) The dispatch's named gate family plus the re-derivation from the real diff (`node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands`, no paths, at b52fcc23): 21 gates, every one exit 0; the derivation at this head returns the dispatch list MINUS `node scripts/pm/bare-root-worklist.mjs --self-test`, which was run anyway per the card's clause and is green ('OK self-test: 69 live row(s) ... none stale, none missing, none contradicted'). (4) --commands for ci.yml and pr-automation.yml is byte-identical base to head: md5 59cf418666b26b5fb80386b8f8ab54cc both, 37 lines, `cmp` silent. (5) ABLATION from the COMMITTED state, no build or dist involved (this script runs from source): the naming of the remainder in renderedArgv was replaced with an inert binding; landing proved on disk BEFORE measuring — removed-text hits 1 to 0, injected-marker hits 1, worktree blob 1be05934 differing from the HEAD blob 36500aff. Direction predicted and observed: turns red, '✗ dispatch-gates self-test: 4 of 1343 case(s) failed', the four being the truncation-not-runnable case, the terminator-in-quoted-value case, the shape-level mutual-exclusivity case and the renderedArgv unit pin. Restore leg proved symmetrically: `git checkout HEAD -- ABSOLUTE_PATH` under a trap with an absolute REPO_ROOT, restored blob 36500aff equal to the HEAD blob, `git diff HEAD` empty (0 bytes), marker hits back to 0, naming back to 1. (6) The script's OWN suites, owed on top of the derived families: its --self-test (green, above) and scripts/pm/check-dispatch-gates.mjs via check:pm-dispatch-gates (green). `git grep dispatch-gates` over test files returns five, all prose comments, none pinning this script. (7) Control-byte self-scan of the edited file and of the PR body: no match (grep exit 1). NOT MEASURED, in its own words: check-test-completeness is a value-bearing family. CI convergence is the PM's, per the dev contract — this report lands at draft-PR time.",
  "mcp_calls": "0 — the repo-scoped REST probe returned 200, so PR creation, the additive label write, both label read-backs and the PR-body read-back all went through REST; the card body and the PM claim were read through the public-repo embedded JSON payload channel. No MCP GitHub call was made this run.",
  "open_questions": [],
  "out_of_scope_findings": []
}

---

Generated by Claude Code