Skip to content

[finding] platform-objects' vitest alias rationale names 'the only suite' that imports @objectstack/lint as a value — there are already three, and the comment licenses a removal it no longer justifies #16081

Description

@claude

Filed by the PM dispatch loop on behalf of the #15629 round (PR #16076), which measured it but could not file it itself — its mandatory dedupe search had no working channel (MCP search_issues answered "API rate limit already exceeded"; REST /search/issues answers 403 "sessions are bound to their configured repositories", with a repo-scoped control returning 200 in the same read). ⛔ Filing without dedupe is the forbidden shape, so it reported instead. ⛔ Unassigned and ungraded — domain:*, type and priority are triage's.

The finding

packages/platform-objects/vitest.config.ts documents its @objectstack/lint alias as existing for one named suite:

managed-api-method-affordance-sweep.test.ts (#7934) — the only suite here that imports a sibling package as a VALUE

That is already false on main, before the #15629 change. Two other suites in the same package import values from @objectstack/lint:

  • sys-user-preference.organization-unique.test.ts
  • pages/canonical-expression-envelopes.test.ts

and #15629's new sys-email.highlight-fields-resolve.test.ts makes four.

Why it is worth a card rather than being left as a stale comment

⭐ The sentence is not decoration — it is the recorded rationale for a load-bearing alias. A future author trimming test config on the strength of "the only suite" could delete the alias believing that removing or rewriting one test had freed it, and take three other suites down with it.

⇒ The defect class is a comment that licenses a removal it no longer justifies, which is worse than a comment that is merely out of date.

Not asserted

No remedy is prescribed here. Whether the right repair is correcting the count, dropping the enumeration in favour of "several suites", or removing the rationale entirely is for whoever routes it — and the alias's own necessity was not re-measured by this seat.

⛔ The #15629 round left vitest.config.ts untouched, correctly: it was outside that card's one-line scope.

Dedupe, with its controls — because a zero is only as good as its control

Enumeration proven COMPLETE: 672 open issues fetched, and the repo's own open_issues_count reads 672.

probe hits
managed-api-method-affordance-sweep 0
sys-user-preference.organization-unique 0
canonical-expression-envelopes 0
the only suite here that imports 0
CONTROL vitest.config 6 — fires
CONTROL platform-objects 33 — fires
CONTROL @objectstack/lint 23 — fires

⇒ No open issue names this. All three controls fire on the same corpus and the same command, so the zeros are real absences rather than a broken instrument.

Refs

#15629 (the card the round was working) · PR #16076 · #7934 (the issue the comment cites)


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions