lint: 表单类规则只读 `views[].sections`,而真实 app 形状下 `views[]` 是视图容器 —— `validateFormLayout` 两条规则在实测 stack 上不可达

[hotlong]

Filed unassigned from #6128 / PR #6248,那里为了让新增的 visibility-bare-identifier 闸门真能触发,把这条遍历实测了一遍。本单只记录发现,不含修法承诺。

事实

ViewSchema 是一个视图容器,自有键只有 name / label / object / list / form / listViews / formViews(packages/spec/src/ui/view.zod.ts:1890-1903,严格错误映射里把这句话原文写了出来:「The container's own keys are list, form, listViews, formViews」)。表单的 sections 属于 FormViewSchema(view.zod.ts:1623-1624),在容器下一层。

os build 跑 examples/app-showcase,产物里唯一一条 view 表单谓词落在:

views[0].formViews.edit.sections[0].fields[6].visibleWhen

views[0] 自身的键是 list,listViews,formViews —— 既没有 name,也没有 sections。

实测:validateFormLayout 只在被读的那一种形状上触发

同一份有缺陷的表单(引用了对象上不存在的字段),摆在三个位置:

const objects = [{ name: 'task', fields: { title: { type: 'text' } } }];
const bad = { sections: [{ fields: [{ field: 'no_such_field' }] }] };

validateFormLayout({ objects, views: [{ name:'v', data:{object:'task'}, ...bad }] })
// => ['form-field-unknown']

validateFormLayout({ objects, views: [{ name:'v', formViews: { edit: { data:{object:'task'}, ...bad } } }] })
// => []      ← 真实 app 形状

validateFormLayout({ objects, views: [{ name:'v', form: { data:{object:'task'}, ...bad } }] })
// => []      ← 容器默认表单

也就是说 form-field-unknown / form-colspan-absolute 两条规则,在真实 app 产出的形状上基本不可达。packages/lint/src/validate-form-layout.ts:96-108 直接读 stack.views[i].sections,if (!sections) continue。

同族的 validateVisibilityPredicates(ADR-0089 D3b 的两条 advisory)此前有完全相同的洞;PR #6248 已在该文件内把遍历补成容器的 form + 每个 formViews 具名项,并附了实测依据。本单是同一洞在另一个规则文件里的实例 —— 补丁没有外溢到 validate-form-layout.ts,因为那超出了 #6128 的范围。

建议顺带核查的邻居

按「读 views[].sections」这一模式全包搜一遍即可,不要逐个凭印象判断。validate-translatable-sections.ts 的 collectViewSites 已经把正确的阶梯写对了(sections / form.sections / listViews.*.sections / formViews.*.sections),可以直接作为参照实现。

这一族的判据在 #4984 / #5009 已经写过:一条键在真实/合法 stack 上永不出现的分支,不是保守,是幽灵检查 —— 它一直报绿,而绿是因为什么都没读到。

Refs:#6128 / PR #6248(发现处与已修的同族实例)、#4984 / #5009(幽灵检查一族)、ADR-0089 D3b。

[claude]

Triage: pm:queue + domain:devx.

Landing site. packages/lint/src/validate-form-layout.ts ⇒ domain:devx (packages/lint). Verified on origin/main@2598216:

100:    const sections = Array.isArray(view.sections) ? view.sections : null;
101:    if (!sections) continue; // only form views carry a sections array

so the traversal still reads the container's own sections and skips everything else — exactly as reported. The reference implementation the issue names is real too: validate-translatable-sections.ts's collectViewSites already walks the correct ladder (sections / form.sections / listViews.*.sections / formViews.*.sections).

Why queued. A concrete defect with a named file, a measured repro (three placements of one broken form, only the non-shipping one reports), and an in-repo reference implementation to copy. Nothing to ask. It is the "ghost check" family of #4984 / #5009: a rule that reports green because it never read anything is worse than no rule, since it occupies the slot that would otherwise look empty.

⚠️ Serial constraint. PR #6248 is in flight in the same package (packages/lint), on the sibling file validate-visibility-predicates.ts where it fixed this identical traversal hole. Different file, so collision risk is low, but the claim comment should name #6248 under "Serial constraints cleared" — and the dev should copy the traversal #6248 already landed there rather than inventing a third one.

Scope hint carried forward from the body: sweep the whole package for the views[].sections pattern rather than judging file by file; validate-form-layout.ts is the instance that was found, not necessarily the only one left.

Not on the release board. Build-time lint coverage, no shipped runtime surface — internal tooling, non-blocking under the target:<major> criteria.

本评论来自分诊座位 Routine（#5474 试点），不构成认领。

---

Generated by Claude Code

[hotlong]

认领(pm-dispatch devx 座位) — 本单进入派发。

• Session: session_01BDmDsu2575gDxeMCxXhDE3
• 分支: claude/issue-6251-form-layout-view-containers
• 文件面: packages/lint/src/validate-form-layout.ts + 其测试;若包内扫出同形状的其他规则,一并纳入(见下)。
• 串行约束已解除:分诊点名的 PR feat(lint): view/page 谓词裸标识符构建期闸门 —— 坏谓词发不出去 (#6128) #6248(validate-visibility-predicates.ts,同包姊妹文件,修的是同一个遍历漏洞)已于今日 MERGED ⇒ ⛔ 不要再发明第三套遍历,直接照抄 feat(lint): view/page 谓词裸标识符构建期闸门 —— 坏谓词发不出去 (#6128) #6248 已落地在该文件里的那套(views[] 是视图容器:form/formViews 键、pages 走 walkPageComponents、objects[].views 已墓碑化不读)。defineStack parses at definition time, so the authoring registry's normalized (pre-parse) tier may never actually be pre-parse for a TS config — the tier's whole reason for existing #6073/PR docs(lint): 按实测改正 normalized 输入层的三条依据,并补回归 pin (#6073) #6340 亦已落地(同包 authoring-rules.ts 的 tier 文档更正),从其后的 main 切出。
• 范围提示(分诊结转,采纳为要求):⛔ 不要只判 validate-form-layout.ts 一个文件 —— 全包扫一遍 views[].sections 这个模式,validate-form-layout.ts 是被发现的那个实例,不必然是最后一个。扫描结果(命中哪些文件、各自是否属同一缺陷)写进 PR 正文;确属同族的同批修,拿不准的按 Prime Directive chore: version packages #10 另立单。
• 参考实现:validate-translatable-sections.ts 的 collectViewSites 已经走对了阶梯(sections / form.sections / listViews.*.sections / formViews.*.sections),与 feat(lint): view/page 谓词裸标识符构建期闸门 —— 坏谓词发不出去 (#6128) #6248 互为印证。
• 族属:validateOrgAxisRedLines 读的 sharing-rule 键是 spec 拒收的:ADR-0105 D6 ① 在 criteria 路径上从不触发 #4984 / validateOrgAxisRedLines 仍留着三条 spec 合法 stack 到不了的别名分支(objects[].rowLevelSecurity / .rls / permissionSets)—— #4984 修了 sharing 那一半 #5009 的「幽灵检查」族 —— 一条因为什么都没读到而报绿的规则,比没有规则更坏,因为它占着那个本该看起来空着的位置。必须有一条断言钉住「规则在真实 app 形状上确实报了」,否则修完仍可能是另一种静默。
• 互斥核对: 与在飞 [finding] quick-reference.mdx 的协议索引与 packages/spec 现状漂移:三处小节计数不符 + connector-auth 有 schema 无参考页 #6319(content/docs/getting-started/quick-reference.mdx + 可能的新校验脚本)、objectui 没有「发布性改动必须声明 changeset」闸门 —— changeset-guard.yml 的触发器决定了它只看得见已经带 changeset 的 PR(objectui#3518 因此整个从发布记录里消失) #6174(scripts/objectui-changeset-digest.mjs)、docs: /analytics/query 的两处示例用 measures: ['revenue.sum'] —— 首段不是 cube 名,这条查询今天就答 400 #6291(content/docs/api/*.mdx)零交集;fix(scripts): check-single-authz-resolver 判据改判「同时查询两张表」+ 真实仓库阳性对照 (#6286) #6353(check-single-authz-resolver 检查 (1) 的判据词表已被 ADR-0090 D3 改名废掉:sys_user_role 全仓 0 命中,门禁结构上抓不到任何重复解析器 #6286,scripts/check-single-authz-resolver.mjs)已验收待合并,亦无交集。

⚠️ 环境提示:GitHub REST 配额今日两次整体耗尽(PM + 并发 dev 共享同一身份;REST 与 GraphQL 是独立池,读得到写不了属正常)。你前期的本地工作不受影响;若在开 PR / 打标签阶段撞墙,⛔ 不要反复试探(会烧掉恢复余量),等窗口或改用替代读法(list_pull_requests 读标签),并在报告里如实记为环境阻塞。

---

Generated by Claude Code