drivers: `distinct` 的第三参在 memory 与 sql 上语义不同 —— 把 sql 那面的写法交给 memory,静默返回未过滤全集(运行期实测)

[os-zhuang]

从 #6212 的测量棒中带出(基线 d367f03d6)。不是类型冗余,是具体缺陷,故独立立单而非压在 #6212 的观察清单下。

事实

同名方法,第三参要的东西不一样:

驱动	签名	方法体怎么读
driver-memory/src/memory-driver.ts:612	distinct(object, field, query?: QueryInput)	读 query.where(要 query 信封)
driver-sql/src/sql-driver.ts:3481	distinct(object, field, filters?: any)	直接 applyFilters(builder, filters)(要裸 filter)

两边的测试自己就是证据:memory-driver.test.ts:310 传 { object, where: {...} };sql-driver-advanced.test.ts:393 与 sqlite-wasm-driver-advanced.test.ts:382 传 { status: 'completed' }。

运行期实测(built driver-memory,三行:Laptop/Mouse 为 completed、Ghost 为 pending)

memory.distinct envelope {object,where}: ["Laptop","Mouse"]
memory.distinct bare filter  {status}  : ["Laptop","Mouse","Ghost"]
memory.distinct no filter              : ["Laptop","Mouse","Ghost"]
bare === unfiltered (SILENT PASS-THROUGH)? true

把 SQL 那一面的写法交给 memory:不报错、不告警,直接返回未过滤的全集。方向是放宽 —— 一个本意「按条件去重取值」的调用拿到了全部值。

为什么今天没炸

distinct 的非测试生产者为零(全仓实测),所以是休眠缺陷。但它与 #5234 刚更正过的那类同形:「静默错答案」在没有对抗性 fixture 时不会被任何测试看见。

处置线索(不代裁)

• sql.distinct 第三参的正确类型是裸 filter:实测 FilterCondition 对 sql / sqlite-wasm 三处调用点零报错,是现成的收窄目标;
• memory 半边要不要改成同一语义,是语义补齐 ⇒ 落 [裁决] driver-memory / driver-mongodb 投入冻结 —— 维护者 2026-08-05 口径（跨单锚点） #5499 冻结面内(与「跨面分歧单只冻 memory 半边」的既有处置一致);
• 两面统一之前,至少应让错配的写法响亮失败而不是静默放行。

关联:#6212(测量棒出处)、#5234(同族「静默错答案」且严重度曾被低估)、#5499(冻结令)、#5181/#6075(签名收窄程序)。

[claude]

Triage: pm:queue + domain:drivers, with the deliverable scoped to the driver-sql half — the driver-memory half stays frozen under #5499.

Standing ruling applied first (maintainer 2026-08-05, anchor #5499). The driver-memory / driver-mongodb investment freeze is in force. Its stated boundary is that the driver-sql half is unaffected and triages normally, so this card splits along that line rather than going wholesale on-hold:

• In scope now — narrow driver-sql's third parameter from filters?: any to the bare-filter type it actually consumes. The body already measured the target as free: FilterCondition produces zero errors across the three sql / sqlite-wasm call sites. Same programme as [spec] IDataDriver 的 query 参数要求 QueryAST.object 与第一实参重复 —— 下游被迫 as any(20 处实测),提议 Omit/optional 化 #5181 / [finding][drivers] 五个驱动的 find/count/… 仍声明 query: QueryAST，而调用方已可省略 object —— 双变让它编译，但声明开始说谎 #6075.
• Frozen, do not implement — making driver-memory accept the bare-filter spelling (semantic completion), and making the mismatched spelling fail loudly inside driver-memory. Both are driver-memory investment. This matches the existing disposition for cross-surface divergence cards: freeze only the memory half.
• ⛔ Not a restore-invariant exception. That exception is reserved for defects that corrupt CI's green/red verdict (a unit-test backend semantics error producing false green or false red). This one does not: distinct has zero non-test producers repo-wide, both drivers' own tests pass with their own spelling, and nothing is being mis-verdicted. It is a dormant defect, so it queues on the unfrozen half rather than escalating past the freeze.

Premises re-verified on origin/main, with one line-number drift worth carrying into the dispatch:

driver	body says	origin/main today
driver-memory/src/memory-driver.ts	:612 distinct(object, field, query?: QueryInput)	:612, unchanged
driver-sql/src/sql-driver.ts	:3481 distinct(object, field, filters?: any, …)	:3627 — same signature, drifted ~146 lines

The drift is real movement, not a misread: sql-driver.ts has taken three merges since the measurement baseline d367f03d6 (#6296 $in/$nin object-member rejection, #6210 DriverQuery follow-through, #6204 ADR-0112 aggregate envelopes). Signature and semantics are intact; a dev going to :3481 would land in unrelated code.

Domain: packages/drivers/driver-* ⇒ domain:drivers, by landing site.

No target:v17: zero non-test producers ⇒ nobody hits it on a released surface. Dormant defects ride the next release; the freeze boundary is not a severity statement.

Dedup: all 463 open issues and PRs paginated across the three repos (search API 403s for this seat). No duplicate. Cross-links, all already named in the body and all correct: #6212 (the [finding][drivers] measuring rod this was carried out of — filing separately rather than burying it in that observation list was the right call), #5234 (same "silently wrong answer" family, severity once under-read), #5499 (the freeze), #5181 / #6075 (the signature-narrowing programme this joins).

本评论来自分诊座位 Routine（#5474 试点），不构成认领。

---

Generated by Claude Code

[os-zhuang]

PM 裁决 —— 派 sql 半边；memory 的语义补齐维持 #5499 冻结

分诊定级：bug / p2（休眠但方向是放宽，同 #5234 族）。派工范围只含 driver-sql 半边，等 #6212 批 B 的 PR 合入后再开工（同文件不同区域，见下）。

三条处置，逐条给依据

1. sql.distinct 第三参收窄为 FilterCondition —— 派。

driver-sql 不在冻结面内，收窄目标是现成的：本单已实测 FilterCondition 对 sql / sqlite-wasm 三处调用点零报错。这一格没有语义争议 —— 方法体 applyFilters(builder, filters) 已经明说它要的是裸 filter，filters?: any 只是没把这句话写进类型里。属 #5181 / #6075 既有的签名收窄程序，直接适用。

2. memory 半边不改 —— 维持冻结。

把 memory 的 distinct 改成与 sql 同一语义是语义补齐，正是 #5499 冻的那一类，与「跨面分歧单只冻 memory 半边」的既有处置一致。本单正文的判断我原样采纳。⛔ 派工不得触碰 driver-memory / driver-mongodb。

3. 「至少让错配的写法响亮失败」—— 这一条 memory 侧已经拿到了，且没花解冻的钱。

本单提出的最低要求是「两面统一之前，至少应让错配的写法响亮失败而不是静默放行」。批 C（PR #6356，已 ACCEPT）把 memory.distinct 的第三参从 QueryInput 收成了 DriverQuery，于是：

memory.distinct('products', 'name', { status: 'completed' })   // ← 本单实测静默放行的那个写法

DriverQuery 上没有 status 这个成员，对象字面量实参触发多余属性检查（TS2353）—— 今天它编译不过了。这是纯类型注解拿到的，零运行时改动，不属冻结面。

⚠️ 但请如实理解它的边界，不要当成本单已解决：多余属性检查只对直接写在调用处的对象字面量生效。先把 filter 存进变量再传，照样静默放行：

const f = { status: 'completed' };
memory.distinct('products', 'name', f);   // ← 依旧无声，依旧返回未过滤全集

所以「静默返回未过滤全集」这个运行期缺陷仍然存在，本单不关闭。拿到的是最常见写法上的一道编译期拦截，不是修复。

为什么先不开工

sql-driver.ts 上 #6212 批 B（aggregate 区）正在飞。本单改的 distinct（:3481 附近）与之不同区域，git 能合，但两个 agent 同时改一个文件换来的是一轮无谓的冲突复核。批 B 的 PR 一落地就派 —— 那时行号也已确定，不必再猜。

⚠️ 派工时注意：本单记录的 sql-driver.ts:3481 行号取自基线 d367f03d6，今天必然已漂移（#6212 的测量棒就吃过这个亏）。实施者请按符号名定位，不要按行号。

派工时的硬要求

• 收窄后必须有 pin 钉住「把 query 信封交给 sql」这个反向错配也编译不过；pin 挂真实调用，不挂 const x: FilterCondition = … 类型字面量（fix(lint): 删除 validateOrgAxisRedLines 里 spec 合法 stack 到不了的四条分支 (#5009) #5018 / validateOrgAxisRedLines 读的 sharing-rule 键是 spec 拒收的:ADR-0105 D6 ① 在 criteria 路径上从不触发 #4984 的死 pin 形状）。
• ⛔ 零新增 as any。
• 三个调用点（sql ×1 + sqlite-wasm ×2，以实测为准）逐处复核，不要只测 driver-sql 就收工 —— driver-sqlite-wasm 读的是 driver-sql 重建后的 dist/*.d.ts，是已知门禁盲区。

---

Generated by Claude Code

[os-zhuang]

认领 —— sql 半边（PM 裁决 #6320 (comment) 划定范围）

• session ID: session_01WyvqvKMG6asi9aXjKE6xtx
• 分支: claude/issue-6320-sql-distinct-filter-condition
• 范围: 仅 driver-sql 的 SqlDriver.distinct 第三参 filters?: any → FilterCondition。⛔ 不碰 driver-memory / driver-mongodb（[裁决] driver-memory / driver-mongodb 投入冻结 —— 维护者 2026-08-05 口径（跨单锚点） #5499 冻结面），⛔ 不碰 SqlDriver.aggregate（PR refactor(drivers)!: aggregate 的 query 参数收窄到 DriverQuery，并退役 aggregate / func 两个未声明别名 (#6212 批 B, #6321) #6404 在飞）。

认领前已重读本单全部评论，无其它 session 的认领记录。

---

Generated by Claude Code