[finding][spec] SkillTriggerConditionSchema.value is not operator-constrained either — the consumer coerces instead (dormant twin of #6227)

[os-zhuang]

Out-of-scope observation from implementing #6227, recorded per PD #10. Unassigned, not queued — filed for triage grading. Duplicate search: no open issue matches SkillTriggerCondition or triggerConditions operator value shape.

Fact

SkillTriggerConditionSchema (packages/spec/src/ai/skill.zod.ts:20-29) has the same operator/value decoupling #6227 fixes on ViewFilterRuleSchema:

operator: z.enum(['eq', 'neq', 'in', 'not_in', 'contains']),
value: z.union([z.string(), z.array(z.string())]),

{ field: 'userRole', operator: 'in', value: 'admin' } — a set operator with a scalar — parses today, exactly like the #6227 shape did.

Why this is an OBSERVATION and not the same defect

Measured in the consumer rather than assumed. SkillRegistry.evaluateCondition (cloud repo, packages/service-ai/src/skill-registry.ts:171-181) normalizes the scalar itself:

case 'in': {
  const list = Array.isArray(expected) ? expected : [expected];
  return list.includes(fieldValue as string);
}

So there is no two-stage failure here — nothing 400s or 500s, and the scalar evaluates to the predicate an author would expect. This is the key difference from #6227, whose runtime half genuinely refuses the shape (assertListComparandShapes, 400 INVALID_FILTER). Nothing a user hits today, hence finding and no pm:queue.

Why it is still worth recording

It is a consumer-side lenient coercion standing in for a contract the producer surface never declared — the Array.isArray(x) ? x : [x] shape the repo's contract-first rule treats as the wrong side of the fix. The cost is not a broken query but a second dialect: triggerConditions accepts two spellings of one predicate, and only one of them is what an author reading the schema would write. For a surface whose authors are increasingly AI-generated, "declared = enforced" is the property that keeps generated metadata honest.

Note the two surfaces are genuinely independent — triggerConditions is evaluated by the cloud agent runtime (skill.zod.ts:212: "evaluated by the cloud agent runtime only"), NOT lowered through AST_OPERATOR_MAP into an objectql filter — so #6227's fix does not reach it and no shared helper covers both today.

Options, if graded live

• A. Constrain value by operator, mirroring [finding][spec] ViewFilterRuleSchema.value 不按算子约束形状 —— 集合算子配标量在发布期通过,直到运行时才拿到 400 #6227 (in/not_in require an array), and drop the consumer's coercion. Contract-first; costs a breaking-ish tightening on a surface with unmeasured external authorship.
• B. Leave the schema, delete nothing, and record the coercion as deliberate in the consumer's docblock.
• C. Leave as-is (current state): the tolerance is undocumented and invisible from the schema.

No recommendation pre-empted — the "real business need" axis (who actually authors triggerConditions, and whether any of them write the scalar form) is not measurable from this repo, and that measurement should drive the call.

Refs: #6227, PR for #6227, #5869.

---

Generated by Claude Code

[os-zhuang]

Findings-triage disposition: hold (finding + domain:spec unchanged).

• Premise re-check: packages/spec/src/ai/skill.zod.ts on origin/main @ 3415a61 still declares operator: z.enum(['eq','neq','in','not_in','contains']) with value: z.union([z.string(), z.array(z.string())]) — unchanged since filing; [finding][spec] ViewFilterRuleSchema.value 不按算子约束形状 —— 集合算子配标量在发布期通过,直到运行时才拿到 400 #6227's fix does not reach this surface, matching the card's independence analysis (triggerConditions is evaluated by the cloud agent runtime only, not lowered through AST_OPERATOR_MAP).
• Why held rather than promoted: no two-stage failure exists — the only consumer normalizes the scalar (skill-registry.ts Array.isArray(expected) ? expected : [expected]), so nothing a user hits today; and the A/B/C fork turns on who actually authors triggerConditions, which is not measurable from this repo.
• Why still kept (restart conditions): real declared≠enforced hygiene gap on an increasingly AI-authored surface. Promote when any of: (a) a maintainer contract-first ruling lands on the operator/value family; (b) evidence surfaces of external triggerConditions authorship where the two-dialect acceptance does damage; (c) the cloud consumer's coercion is removed — at which point this becomes exactly the [finding][spec] ViewFilterRuleSchema.value 不按算子约束形状 —— 集合算子配标量在发布期通过,直到运行时才拿到 400 #6227 defect and queues without further debate.

本评论来自分诊座位 Routine（#5474 试点），不构成认领。

---

Generated by Claude Code