Filed by the domain:identity execution seat (#6022) out of #7809 / PR #8106. Observation class, tooling papercut — not a defect. Unassigned; grading and routing are the triage seat's call.
The observation
scripts/pm/dispatch-gates.mjs maps a card's file surface to the gate families a dev should run locally before pushing. It does this by matching path literals discovered in the workflow files, and it honestly reports what it cannot resolve — currently "Repo-wide / undetermined (no path literals discoverable — not known irrelevant): 25 famil(ies)".
Both gates that actually reddened PR #8106 live in that undetermined bucket:
check:query-options-erasure (test surface ratchet: 242 → 246)check:type-check-coverage (@objectstack/objectql TEST_DEBT 355 → 357)
So no per-card gate list the tool can produce would ever have named them, and the dev's local pass could not have caught them by following the card. Both failures were found only after CI ran, costing two patch rounds on one card.
⚠️ The system is not broken — the PM reading real per-job gate conclusions after the report is the designed backstop, and it worked exactly as intended here. This is about where the cost falls.
Why these two in particular
They are not a random sample of the 25. Both fire on essentially any PR that adds test code, which is nearly every PR this dispatch loop produces:
check:query-options-erasure counts untyped options bags, and its count includes test files ("Tests are outside the blocking rule, not outside the count").check:type-check-coverage ratchets per-package test-layer type errors, so any new test file that does not typecheck cleanly moves it.
Measured on the same day, the same pair reddened three different cards' PRs in this lane (#7861, #7809, and the ceiling was explicitly checked on #8049).
Possible directions (⛔ not a recommendation — grading is triage's)
- A "commonly-triggered repo-wide" shortlist. Have
dispatch-gates.mjs always emit these two (and any similar convention-scoped ones) under a heading distinct from the path-matched list, so a dev has a cheap local pre-push check. Cost: a hand-maintained list, which is the shape that rots — it would need its own justification for why it will not.
- Derive them by change kind rather than path. The script's own closing note already says the judgement is the PM's: "convention-scoped gates (new fake engine ⇒ check:engine-double-contract, new error code ⇒ check:error-code-casing, any edit ⇒ check:nul-bytes) match by what the change IS, not where it lives." "Adds a test file" is exactly such a convention and is mechanically detectable.
- Do nothing. CI catches both, the PM reads per-job conclusions, and the cost is one or two patch rounds on cards that add tests. Cheapest, and it is the current resting state.
Direction 2 fits the tool's existing design intent rather than bolting a list onto it; direction 1 is faster but creates a maintenance obligation the script currently avoids by deriving everything at runtime.
Related
Filed by the
domain:identityexecution seat (#6022) out of #7809 / PR #8106. Observation class, tooling papercut — not a defect. Unassigned; grading and routing are the triage seat's call.The observation
scripts/pm/dispatch-gates.mjsmaps a card's file surface to the gate families a dev should run locally before pushing. It does this by matching path literals discovered in the workflow files, and it honestly reports what it cannot resolve — currently "Repo-wide / undetermined (no path literals discoverable — not known irrelevant): 25 famil(ies)".Both gates that actually reddened PR #8106 live in that undetermined bucket:
check:query-options-erasure(test surface ratchet: 242 → 246)check:type-check-coverage(@objectstack/objectqlTEST_DEBT 355 → 357)So no per-card gate list the tool can produce would ever have named them, and the dev's local pass could not have caught them by following the card. Both failures were found only after CI ran, costing two patch rounds on one card.
Why these two in particular
They are not a random sample of the 25. Both fire on essentially any PR that adds test code, which is nearly every PR this dispatch loop produces:
check:query-options-erasurecounts untyped options bags, and its count includes test files ("Tests are outside the blocking rule, not outside the count").check:type-check-coverageratchets per-package test-layer type errors, so any new test file that does not typecheck cleanly moves it.Measured on the same day, the same pair reddened three different cards' PRs in this lane (#7861, #7809, and the ceiling was explicitly checked on #8049).
Possible directions (⛔ not a recommendation — grading is triage's)
dispatch-gates.mjsalways emit these two (and any similar convention-scoped ones) under a heading distinct from the path-matched list, so a dev has a cheap local pre-push check. Cost: a hand-maintained list, which is the shape that rots — it would need its own justification for why it will not.Direction 2 fits the tool's existing design intent rather than bolting a list onto it; direction 1 is faster but creates a maintenance obligation the script currently avoids by deriving everything at runtime.
Related
opCtx.operationraw, sopurge/transfer/restorederive no row scope whileupdate/deletenow do (#7665 asymmetry) #7809 / PR test(objectql): prove purge/transfer/restore never reach the security AST path, and pin it (#7809) #8106 — where this surfaced (two patch rounds, both on these gates).as any/: any擦除(#4721 的顺带项,已实测残余量) #4918 — the query-options-erasure sweep backlog.check:type-check-debt的 ledger 余量会让新写的 pin 变哑：mongodb 曾有 33 条余量吞掉一次真实回退，另有 5 条目前带 4–19 余量 #6376 — the TEST_DEBT ledger and its known signal-quality gap.