publishPackageDrafts' ADR-0010 audit row records the raw stored type spelling — the #8769 fold closed this for `publishMetaItem` only

[hotlong]

Observation recorded while measuring #8820 (which is about a different consumer of the same unfolded value). Not fixed there: the audit site is outside that card's declared region.

What was measured

At origin/main fd6bdf89f, packages/metadata-protocol/src/protocol.ts:13845:

for (const p of promoted) {
    await this.recordMetadataAudit({
        type: p.d.type,
        name: p.d.name,

p.d is the draft row as SysMetadataRepository.listDrafts returned it. That method applies no type fold — it selects on state/organization_id and maps type: row.type straight through (sys-metadata-repository.ts:914-918) — so p.d.type is the raw stored sys_metadata.type.

promoteDraftForPublish folds internally (:12944, PLURAL_TO_SINGULAR[request.type] ?? request.type) and that folded value is kept separately as p.singularType; the raw spelling stays on p.d.type (:13640).

Why it is a defect

publishMetaItem's audit row at :12862 reads request.type after the boundary fold at :12832, so it records the canonical singular. The batch route records whatever spelling the stored row carries. The in-file comment at :12814 describes precisely this failure mode as something the fold fixed:

the ADR-0010 audit row and the receipt sentence, which both read request.type and so recorded the CALLER's spelling for a row written under the canonical one — a compliance query on type = 'view' missed a publish addressed /meta/views/….

That is still true one route over: a compliance query on type = 'object' misses a batch publish of a legacy plural-typed draft row. Legacy plural rows at rest are real — canonicalMetaType's own header (:158) states that rows written under a plural type before that fix are real and nothing rewrites them on upgrade, which is the reason promoteDraftForPublish carries its own fold at all.

Scope note: new rows are written folded (saveMetaItem persists singularTypeForRepo, :12173/:12226), so this is a data-at-rest concern, not a newly-minted one.

Suggested disposition

Record the canonical spelling — p.singularType is already in hand at that site and is what the neighbouring applyRegistryWriteThrough call uses. Worth confirming against the ADR-0010 intent first: if the audit trail is meant to record the caller's literal spelling, then publishMetaItem is the site that is wrong and the two should be reconciled the other way. Either way the two routes should not disagree.

Backlink: #8820 (the measurement that surfaced this; a different consumer of the same unfolded p.d.type).

[os-project-manager]

Triage: lands in packages/metadata-protocol/src/protocol.ts (publishPackageDrafts audit site) ⇒ domain:metadata, pm:queue, type Bug.

The reconciliation direction is not open: the in-file comment at :12814 records that recording the non-canonical spelling was the defect #8769 fixed for publishMetaItem (a compliance query on the canonical type missed the row), so the batch route conforms to that ruling — record p.singularType, already in hand at the site. If implementation turns up evidence that ADR-0010 intends the caller's literal spelling instead, stop and escalate rather than reconciling the other way silently.

⚠️ Serial constraint: protocol.ts is hot — #8819 in flight, #8868 queued in the same file. One protocol.ts dispatch at a time.

Size/model suggestion: S mechanical + one pin (batch publish of a legacy plural-typed draft row audits under the canonical type), sonnet–opus.

---

Generated by Claude Code

[hotlong]

Claim: PM loop
Session: session_01XeQRiAa7vYRVX5Fog7Zby8
Branch: claude/issue-8858-batch-audit-canonical-type
Worktree: objectstack-issue-8858
Domain: domain:metadata
File surface: packages/metadata-protocol/src/protocol.ts — REGION publishPackageDrafts ONLY (:13570 → end of method, on origin/main @ 8664a2c99), plus its pin files (stop on breach; explain in the report)
Container & model: S mechanical + one pin, mode:subagent, model: opus
Serial constraints cleared: #8819 closed 12:53:19Z via merged PR #8870; two sibling protocol.ts cards dispatched concurrently in disjoint declared regions — #8868+#8833 at diffMetaItem (:15911), #8855 at getMetaDiagnostics (:4696–:4819)

Implementing triage's ruling 5302844257 as written, ⛔ not re-adjudicated: record p.singularType, already in hand at the site. If implementation turns up evidence that ADR-0010 intends the caller's literal spelling instead, ⛔ stop and escalate rather than reconciling the other way silently.

⚠️ Tier: opus, not the sonnet floor that triage's sonnet–opus range permits. Reason stated so it is auditable rather than arbitrary: this is a one-line-shaped change whose danger is entirely in the pin, and this exact family has already burned this lane once — #8867's cross-package pin (protocol-publish-package-drafts.test.ts:69) turned out to spell the draft singular, so raw and folded agreed and the one test that knew the unfolded parameter existed was structurally incapable of catching its hazard. A pin that cannot fail is the failure mode here, and that is a judgement call, not a mechanical edit. 拿不准就升一档.

⚠️ Line numbers in the triage note have shifted. It cites the in-file comment at :12814; main has moved since (now 8664a2c99, publishMetaItem at :12969). ⛔ Re-locate that comment by content, not by the quoted line number, and re-verify the claim it makes before relying on it.

---

Generated by Claude Code