Skip to content

chore(console): bump the objectui pin d8ec8d6d → 67dadd602a3a - #14295

Merged
os-zhuang merged 4 commits into
mainfrom
claude/objectui-objectstack-testing-105da4
Sep 2, 2026
Merged

chore(console): bump the objectui pin d8ec8d6d → 67dadd602a3a#14295
os-zhuang merged 4 commits into
mainfrom
claude/objectui-objectstack-testing-105da4

Conversation

@hotlong

@hotlong hotlong commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

Moves .objectui-sha from d8ec8d6d4f01 to 67dadd602a3a (objectui origin/main tip, 24 commits / 16 releasing changesets). The generated @objectstack/console changeset lists the range; its ADR-0087 disposition is not-required (no-migration-prescription) — both declared-breaking entries (DataTableSchema.toolbar retired in @object-ui/types, objectui#6881; form-view section className/gridClassName reads retired in @object-ui/plugin-form, objectstack#13626) are objectui-internal and touch no packages/spec surface.

Pin citations re-measured (check:objectui-pin-citations)

The eight asserting citations in packages/spec were re-READ at objectui@67dadd602, never sha-swapped:

  • plugin-grid/src/ObjectGrid.tsx changed across the move (7 commits, 461 lines): the bulk-selection block cited at d8ec8d6d4:3187-3202 sits byte-identical at 3436-3451, shifted only by insertions above it. hooks/useBulkExecutor.ts is unchanged; 284-289 re-read and still ends on label = 'bulk delete'.
  • components/src/renderers/layout/containers.tsx changed (164 lines) from :995 on, below every cited anchor: the tabs icon block 729-735 / registration input 788 and the accordion icon block 918-924 / input 965 are unmoved, text re-read.
  • button.tsx, action/resolve-icon.ts, lib/lazy-icon.tsx, plugin-dashboard/src/index.tsx, ObjectMetricWidget.tsx, MetricWidget.tsx, MetricCard.tsx are byte-identical at both pins; every anchor (button.tsx:36/57/59, resolve-icon.ts:14-24/30-35, lazy-icon.tsx:66-92, index.tsx:194/204, ObjectMetricWidget.tsx:142/474, MetricWidget.tsx:312-321/373-382, MetricCard.tsx:83) re-read, none moved.

Verification

  • pnpm objectui:build at the new pin: bundle canary present, injected spec verified, dist 50660 KB.
  • pnpm sdui:manifest (the pin bump's second half, ADR-0082 D4): no new declaration divergence vs the accepted baseline (90 pre-existing spec-only divergences, 0 blocks missing from the registry).
  • pnpm --filter @objectstack/spec build && check:generated: all 15 generated artifacts up to date after the docblock edits; check:objectui-pin-citations green locally (8 asserting, 13 historical); component.test.ts + api-methods-batch-conformance.test.ts pass (234 tests).
  • node scripts/check-adr-0087-registration.mjs --base origin/main passes.
  • Browser dogfood of the showcase on the rebuilt console (records CRUD, all 7 list visualizations, dashboards/reports, approvals inbox, Studio, Setup, i18n switch): findings tracked separately; none is a regression introduced by this range.

Not in this PR

.claude/launch.json (local dev-server entry used for the dogfood run) is deliberately left out — governed surface.

🤖 Generated with Claude Code

Lockstep record

check:sdui-lockstep refuses a pin move whose parity record names the old pin; pnpm gen:sdui-lockstep was run against the objectui tree at 67dadd602a3a (the .cache/objectui-67dadd602a3a build worktree — the shared sibling checkout sits at an older HEAD and does not carry the ported block): 214 grammar lines byte-identical, 24 diagnostic codes agree, no port owed.

fix(plugin-grid,plugin-list): FLS-gate the `$expand` projection at both sites (#7229)

objectui@67dadd602a3a891666ea1513c5de677140784b6a
@github-actions github-actions Bot added size/s documentation Improvements or additions to documentation tooling labels Sep 2, 2026
check:objectui-pin-citations refuses a pin bump whose asserting citations
still name the old pin, and refuses a sha-only rewrite. Every record was
re-read at objectui@67dadd602 instead:

- ObjectGrid.tsx changed (7 commits, 461 lines): the bulk-selection block
  moved 3187-3202 → 3436-3451, byte-identical, shifted by insertions above.
  hooks/useBulkExecutor.ts is unchanged; 284-289 re-read.
- containers.tsx changed (164 lines) from :995 on, below every cited
  anchor: 729-735 / 788 (tabs) and 918-924 / 965 (accordion) unmoved.
- button.tsx, resolve-icon.ts, lazy-icon.tsx, plugin-dashboard index.tsx,
  ObjectMetricWidget.tsx, MetricWidget.tsx, MetricCard.tsx are
  byte-identical at both pins; every anchor re-read, none moved.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@github-actions github-actions Bot added size/m and removed size/s labels Sep 2, 2026
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 2 package(s): @objectstack/sdui-parser, @objectstack/spec, touching 4 documentable anchor(s). ⚠️ 1 changed file(s) yielded no anchor (packages/sdui-parser/objectui-lockstep.json), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files.

1 release-owned page(s) name something this change touched. These are read-only:

  • content/docs/releases/v15.mdx (via PageTabsProps (symbol, a top-level const object))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • 1 changed file(s) yielded no anchor (packages/sdui-parser/objectui-lockstep.json) — pages documenting those are invisible to this run
  • the SDK route bridge reached 47 of 219 client-bound route-ledger rows — the other 172 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 172: 14 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 56 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 102 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 129 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 9c7d9d4b343f5ded5b51b757cb4251d1f68cd378packageMentionDocs.

Which tree this was computed on

This run read content/docs from 36857115db2521ba1c2f8b210403df998b78ff2d — the merge of head ec0c8c1284271b29424e21d75a94c74573178f1a into base 9c7d9d4b343f5ded5b51b757cb4251d1f68cd378, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin 36857115db2521ba1c2f8b210403df998b78ff2d && git checkout 36857115db2521ba1c2f8b210403df998b78ff2d
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 9c7d9d4b343f5ded5b51b757cb4251d1f68cd378 ec0c8c1284271b29424e21d75a94c74573178f1a && git checkout -B drift-repro 9c7d9d4b343f5ded5b51b757cb4251d1f68cd378 && git merge --no-ff ec0c8c1284271b29424e21d75a94c74573178f1a

node scripts/docs-audit/affected-docs.mjs --json 9c7d9d4b343f5ded5b51b757cb4251d1f68cd378

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs 9c7d9d4b343f5ded5b51b757cb4251d1f68cd378 → pass the list as
args.docs, on the commit named under Which tree this was computed on.

hotlong and others added 2 commits September 2, 2026 11:09
check:sdui-lockstep refuses a pin move whose parity record still names the
old pin. Re-recorded with --update against the objectui tree checked out at
the pinned SHA: 214 grammar lines byte-identical, 24 diagnostic codes agree,
no port owed.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…dadd602

check-sdui-manifest refuses a pin move whose manifest record names the old
pin. Regenerated with gen-sdui-manifest-node against @object-ui 17.6.0 (the
version the new pin ships): 57 components, content unchanged, record moved
to 67dadd602a3a.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@os-zhuang
os-zhuang marked this pull request as ready for review September 2, 2026 14:26
@os-zhuang
os-zhuang enabled auto-merge September 2, 2026 14:26
@os-zhuang
os-zhuang added this pull request to the merge queue Sep 2, 2026
Merged via the queue into main with commit 7642aac Sep 2, 2026
36 checks passed
@os-zhuang
os-zhuang deleted the claude/objectui-objectstack-testing-105da4 branch September 2, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants