fix(release): cut-rc.yml's hotcrm smoke warning no longer claims pre-exit re-arms the gate - #14610
Merged
Merged
Conversation
…exit re-arms the gate The step's warning string and its comment both keyed the gate's re-arm event to `changeset pre exit`, which release.yml's own comment records was superseded (#8643): pre-exit fired and the deadlock stood anyway, because a migrated hotcrm release did not exist yet. release.yml's gate now keys the same posture on shipping a migrated hotcrm release and bumping HOTCRM_REF (+ BLOCKING=1), and its warning already says so. This mirrors that wording into cut-rc.yml's warning and drops the "#3600 amendment" keying from the step comment in favor of the actual reason this lane's step is advisory: it has no BLOCKING switch and only ever runs in pre mode. No logic change — if:/env:/run: control flow and HOTCRM_REF are untouched, and release.yml is untouched.
baozhoutao
marked this pull request as ready for review
September 2, 2026 15:17
baozhoutao
enabled auto-merge
September 2, 2026 15:17
baozhoutao
deleted the
claude/issue-9828-cut-rc-hotcrm-smoke-rearm-text
branch
September 2, 2026 16:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9828
What changed
.github/workflows/cut-rc.yml'sDownstream backward-compat smokestep — the step comment (:868-873), the::warning::string (:882) — is the only edit.release.ymlis untouched.Before
After
Why
The old text told a release curator that
changeset pre exitre-arms the gate.release.yml's own comment (:1153-1178) records that this was superseded: pre-exit fired (#8643, 2026-08-14) and the deadlock persisted anyway, because a migrated hotcrm release did not exist yet — the keying was the bug, not the event.release.yml's gate now keys re-arm on shipping a migrated hotcrm release + bumpingHOTCRM_REF(+BLOCKING=1), and its own::warning::(:1199) already says so. This PR mirrors that wording intocut-rc.yml's warning so both lanes state the same condition in the same words, and points the step comment atrelease.yml's comment as the single record of why the gate is advisory, rather than restating an outdated reason.The step comment also dropped the "#3600 amendment" keying, which is the same superseded fact. This lane's step is advisory for a different, still-true reason than
release.yml's: it carries noBLOCKINGswitch at all, and this lane only ever runs in pre mode. That's now what the comment says.name:(advisory in pre mode) is unchanged — it's literally true on this lane (the rc lane only ever runs in pre mode), so it stays; the reasoning is now spelled out in the comment above it rather than in the name itself.No logic change:
if:,env:(HOTCRM_REF: v2.1.0), and therun:control flow (if bash scripts/downstream-smoke.sh; then … else … fi, the::notice::branch) are untouched. This step stays advisory and keeps emitting::warning::on failure, same as before.Verification
git diff --stat— exactly one file:.github/workflows/cut-rc.yml, 6 insertions / 6 deletions.git diff origin/main -- .github/workflows/release.yml— empty (untouched).git grep -n "re-arms that gate\|advisory in pre mode\|Downstream backward-compat smoke" -- scripts content docs .github— after the change,re-arms that gatehas zero hits anywhere in the tree;advisory in pre modeandDownstream backward-compat smokeeach hit only the two workflows' step names, confirming nothing underscripts/,content/, ordocs/reads or tests this warning string or step name (the "check whether anything tests the claim" item from PM comment 5337063017).Gates
Derived via
node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands .github/workflows/cut-rc.ymlon this branch — 21 commands (11 pnpm, 10 direct node); reconciled21 derived, 21 run, 0 NOT-MEASURED, 0 UNRUNvia--ran. All 21 ran green, including the heavypnpm check:pm-dispatch-gatesself-test (1240/1240 cases). Re-verified the 10 direct-node gates and (separately, contention permitting) the fast pnpm ones after twoorigin/mainmerges during the run (final treea5b95ee6emerged in); the derived union stayed identical (same 21 commands) at each re-derivation, and neither merge touched.github/workflows/cut-rc.ymlorrelease.yml.check-nul-bytesclean.This is
.github/**-only with no package publish —skip-changesetlabel applied.Generated by Claude Code
Generated by Claude Code