docs(skills): spell Plugin.type as PluginType in objectstack-platform - #14981
Merged
Conversation
The skill's copy of the Plugin interface still spelled type as an open string with the value set in a trailing comment. #13925 narrowed the published field to the closed PluginType (exported from @objectstack/core), so the skill was teaching a wider accept set than the compiler enforces. Same-length spelling fix at both sites, with the enumeration comment replaced by a pointer to PluginType. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019RfFHiRCSs3JXLK4cwcfox
os-zhuang
approved these changes
Sep 3, 2026
os-zhuang
marked this pull request as ready for review
September 3, 2026 17:47
os-zhuang
enabled auto-merge
September 3, 2026 17:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14589
What changed
skills/objectstack-platform's copy of thePlugininterface still spelledtypeasan open
stringwith the value set carried in a trailing comment, at two sites. #13925narrowed the published field on
@objectstack/coreto the closedPluginType(verifiedon this branch:
packages/core/src/types.ts:105export type PluginType = 'standard' | (typeof CORE_PLUGIN_TYPES)[number];, field at:130type?: PluginType;, and the typeis publicly re-exported via
export * from './types.js';inpackages/core/src/index.ts:21). The skill was teaching a wider accept set than thecompiler enforces.
Two same-length, no-net-growth edits per the triage scope ruling (comment
5514027764
on the card):
skills/objectstack-platform/SKILL.md:723skills/objectstack-platform/rules/plugin-lifecycle.md:48Both now read
type?: PluginType;with a short pointer comment in place of theenumeration (
// closed set exported by @objectstack/core), rather than dropping thecomment outright:
git grep -rn "CORE_PLUGIN_TYPES\|'theme'"etc. againstskills/objectstack-platform/found no other site in the package naming the value set,so per the dispatch's mechanism assumption a minimal pointer stays rather than leaving the
reader with nothing (the enumeration list itself is not restored).
⛔ No sweep of
skills/**for other stale type copies, per the triage ruling's scopelimit.
Line/token budget (skills token ratchet)
Whole-file readings, before → after (
origin/main5bc2f27→ this branch):skills/objectstack-platform/SKILL.mdskills/objectstack-platform/rules/plugin-lifecycle.mdWhole-package totals (
skills/objectstack-platform/**, 5 files): lines 2100 → 2100,tokens 20159 → 20154. Both files shrink individually (net deletions); the package total
shrinks; no file's token ceiling rises.
node scripts/check-skills-token-ratchet.mjsconfirms:
skills/objectstack-platform/SKILL.md 12868 / 12984 (-116),skills/objectstack-platform/rules/plugin-lifecycle.md 1775 / 2408 (-633).Reverse-check
Governed surface
skills/**is a governed surface (AGENTS.md Prime Directive #14): this PR stays draftand is merged by hand by the maintainer after the PM's in-seat review; no agent approves
it and it does not enter the merge queue.
Gates
Derived post-final-commit with
node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstackat9c84135(no paths passed): 21 command(s) apply (16 bypath match + 5 declared whole-tree). Run under
scripts/pm/os-verify-lock.sh, exit codescaptured before any pipe:
node scripts/check-ci-filter-parity.mjs— OKnode scripts/check-closing-keyword-parity.mjs— OKnode scripts/check-comment-mask-corpus.mjs— OK (5824 files, 0 disagree)node scripts/check-cross-package-test-inputs.mjs— OKnode scripts/check-shard-attestation.mjs— OKnode scripts/check-skills-token-ratchet.mjs— OK (see budget table above)node scripts/check-test-completeness.mjs— NOT MEASURED (gate's own text: "thisgate grades a saved
turbo run testlog, and no log was named" — CI tees it; this cardtouches no test files)
pnpm --filter @objectstack/lint run check:doc-formula-expressions— OK (after building@objectstack/formulaand@objectstack/lint's dependency closure, which were notbuilt in the fresh worktree)
pnpm --filter @objectstack/spec run check:skill-docs— OKpnpm check:agent-test-spelling— OKpnpm check:corpus-claim-drift— OKpnpm check:cross-package-test-inputs— OKpnpm check:doc-authoring— OKpnpm check:nul-bytes— OKpnpm check:pm-governed-merges— OKpnpm check:refd-timer-probe— OKpnpm check:role-word— OKpnpm check:skill-compatibility— OKpnpm check:skill-frame-sync— OKpnpm check:skill-identifier-liveness— OKpnpm check:watch-hint-literal— OKRun at
9c84135(git rev-parse --short HEADof this branch's tip).This diff publishes nothing from any package (skill docs only) —
skip-changesetlabelapplied per the os-dev clause.
Generated by Claude Code