docs(pm): drop the stale shadowing claim from dispatch-gates' selfTest comment - #15345
Merged
Merged
Conversation
…t comment PR #14988 replaced the five named `node:path` imports with one namespace binding (`import * as nodePath`), so no module-scope `relative` binding exists for the fixture string to shadow. Restate the standing reason the repo-relative spelling comes from ROOT: it is the prefix every sibling case in the block already joins against, not a workaround. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019RfFHiRCSs3JXLK4cwcfox
os-steve
marked this pull request as ready for review
September 4, 2026 13:04
os-steve
enabled auto-merge
September 4, 2026 13:04
os-steve
deleted the
claude/issue-14991-dispatch-gates-shadowed-comment
branch
September 4, 2026 13:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14991
What
scripts/pm/dispatch-gates.mjscarried a five-line comment insideselfTest(), immediately above thetierOwnAbs/tierOwnRelpair, whose first sentence went stale once PR #14988 replaced the five namednode:pathimports with one namespace binding (import * as nodePath from 'node:path', L420). With that binding shape, no module-scoperelativeexists for theconst relative = [...]fixture (a string-array.join('\n'), still at L12679) to shadow.Verified on this branch's tree:
The
ROOT-derived spelling itself was never a workaround — it is the prefix every sibling case in that block already joins against — so only the stated reason needed restating.Change
Comment-only, one file, no code or assertion change:
5 lines → 4 lines (shorter, not longer).
Verification
Ran on
b0c247c6(rebased ontoorigin/main), throughscripts/pm/os-verify-lock.sh, real verdict lines below (not raw exit codes):Direct-node gates —
VERDICT command-exit 0:pnpm check:*gates —VERDICT command-exit 0:Tooling-script rule (this file is itself a gate/tool script): no
*.test.tsinscripts/pm/tests it directly, and the only repo-widedispatch-gates.mjsmentions outside its own self-test are prose comments in five unrelated test files (packages/cli/test/serve-node-env-production-default.e2e.test.ts,packages/create-objectstack/src/runtime-image.test.ts,packages/objectql/src/action-owner-key-single-source.test.ts,packages/runtime/src/action-owner-key-single-source.test.ts,packages/types/src/driver-error-classification.callers.test.ts) — none import or execute this file; they only cite its self-test's guarantees. The file's own self-test (pnpm check:pm-dispatch-gates, run above) is the complete test-suite obligation here.pnpm check:nul-bytescovers the edited file; also spot-checked withgrep -naP '[\x00-\x08\x0b\x0c\x0e-\x1f\x7f]'— clean.Tooling-only change under
scripts/pm/**—skip-changesetapplies.Generated by Claude Code