chore(spec): agent access/permissions are live — correct stale liveness ledger (#1884 already enforced)#1938
Merged
Merged
Conversation
…ss ledger Investigating the next ADR-0049 "enforce now" item (#1884 agent access-control) found it is ALREADY implemented and tested on main: evaluateAgentAccess() (agent-access.ts) enforces the agent's declared `permissions` (caller must hold all) and `access` allow-list at the chat route (agent-routes.ts:151). It landed after the 2026-06 liveness audit, which still listed these dead — so the audit-seeded ledger was stale. - agent.access / agent.permissions: dead → live (evidence: agent-access.ts:50). - agent.visibility: dead → experimental — intentionally NOT enforced (agent-access.ts:41); the list route doesn't filter by it, and gating listing needs owner/org semantics that aren't plumbed yet. Note: the gate enforces classification *completeness*, not *correctness* — a `dead` entry that silently becomes live (as here) doesn't fail CI. Catching dead→live drift needs a periodic re-audit (cf. the docs monthly cron). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
size/s
documentation
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 89 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While picking up the next ADR-0049 "enforce now" item (#1884, agent access-control), I found it already implemented and tested on main — so this is a ledger-accuracy correction, not new enforcement.
What's already there
evaluateAgentAccess()(agent-access.ts, withagent-access.test.ts) enforces, at the chat route (agent-routes.ts:151):agent.permissions— caller must hold ALL required permissions/rolesagent.access— allow-list by userId/roleIt landed after the 2026-06 liveness audit, which still listed these as dead — so the audit-seeded ledger drifted.
The correction
agent.access/agent.permissions: dead → live (evidence:agent-access.ts:50)agent.visibility: dead → experimental — intentionally not enforced (agent-access.ts:41); theGET /ai/agentslist route doesn't filter by it, and gating listing needs owner/org semantics that aren't plumbed.Gate green: agent 20 live / 5 experimental / 2 dead.
Meta-finding (worth noting)
The gate enforces classification completeness, not correctness — a
deadentry that silently becomes live (exactly this case) does not fail CI. Catching dead→live drift needs a periodic re-audit (cf. the docs monthly cron). I can add that as a follow-up if you want.🤖 Generated with Claude Code