chore(todo): fix owner lookup ref + completed-task seed validation#2008
Merged
Conversation
Two app-todo defects found driving it end-to-end:
1. todo_task.owner was Field.lookup('user') — `user` is not a registered
object/table (the platform user object is `sys_user`), so seed-time owner
resolution flooded "no such table: user". Repointed to `sys_user` and
dropped the unresolvable `owner: 'admin'` seed value (no stable seed key for
the auth-created bootstrap admin).
2. The two `completed` seed tasks omitted `completed_date`, violating the
object's own `completed_date_required` validation → they silently failed to
seed (only 6 of 8 rows loaded). Gave them a completed_date.
Verified: 0 "no such table: user" errors, 0 rule_violations, all 8 rows seed;
validation still rejects a completed task with no completed_date (400);
aggregation/reports unaffected.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
size/s
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two app-todo defects found driving it end-to-end (boot + seed + CRUD over HTTP).
1.
ownerlookup pointed at a non-existent objecttodo_task.ownerwasField.lookup('user', …).useris not a registered object — the platform user object issys_user(better-auth managed). So at seed/owner-resolution time the driver queried ausertable that doesn't exist, flooding the boot log with:Fix: repoint to
Field.lookup('sys_user'), and drop the seedowner: 'admin'(there's no stable seed key for the auth-created bootstrap admin; leaving it unset is correct).2. Completed seed tasks failed their own validation
Two seed tasks are
status: 'completed'but had nocompleted_date— which the object's owncompleted_date_requiredvalidation rejects. They silently failed to insert, so only 6 of 8 rows seeded:Fix: gave the completed seeds a
completed_date.Verification (live boot)
no such table: usererrors, 0rule_violations.todo_tasknow seeds all 8 rows (both completed tasks load).POSTa completed task with nocompleted_date→ 400.Example-app only; no package impact.
🤖 Generated with Claude Code