fix(deps): override undici >=7.28.0 to close GHSA-vmh5-mc38-953g#2044
Merged
Conversation
…953g CI's "Validate Package Dependencies" gate (pnpm audit --audit-level=high) fails on GHSA-vmh5-mc38-953g — undici TLS certificate validation bypass via dropped requestTls in the SOCKS5 ProxyAgent (vulnerable >=7.23.0 <7.28.0). undici 7.27.2 is pulled transitively through the VS Code extension's publish tooling: packages/vscode-objectstack > @vscode/vsce > cheerio > undici. Pin via pnpm-workspace.yaml `overrides` (the repo's canonical location — pnpm v10 ignores package.json `pnpm.overrides`). cheerio@1.2.0 declares undici ^7.19.0, so the override targets only the vulnerable range and forces ^7.28.0 (resolves to 7.28.0) — staying inside the 7.x major cheerio supports rather than jumping to undici 8.x. After the change `pnpm audit --audit-level=high` reports 0 high (exit 0) and `turbo run build --filter=objectstack-vscode` still succeeds. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Close HIGH-severity advisory GHSA-vmh5-mc38-953g (undici TLS certificate validation bypass via dropped
requestTlsin the SOCKS5ProxyAgent) that is failing the Validate Package Dependencies CI gate (pnpm audit --audit-level=high).The vulnerable
undici@7.27.2is pulled in transitively through the VS Code extension's publish tooling only:This is repo-wide and pre-existing (it red-flags the dependency-validation gate for everyone, not just one PR).
How
Add a single transitive pin to
pnpm-workspace.yamloverrides— the repo's canonical location (pnpm v10 silently ignorespnpm.overridesinpackage.json, as documented in that file alongside the existingesbuild/form-data/tar/minimatchpins):>=7.23.0 <7.28.0, patched>=7.28.0.cheerio@1.2.0declaresundici: ^7.19.0, so the override targets only the vulnerable range and forces^7.28.0, which resolves to 7.28.0 — the patched line within the 7.x major cheerio supports. A bare>=7.28.0would resolve to undici 8.5.0, an out-of-range major bump for cheerio; this stays minimal and in-range.package.jsonis intentionally untouched. Change is just the override + lockfile.Verification
pnpm audit --audit-level=high→ 0 high (exit0), gate passes. (Before:1 high= undici.)esbuild,minimatch,tar,form-data).turbo run build --filter=objectstack-vscode→ succeeds.undici 7.27.2 → 7.28.0+ the override line.🤖 Generated with Claude Code