feat(app-showcase): Settings page + preference object#2061
Merged
Conversation
The last of the selected enterprise surfaces. Every enterprise app needs a settings/preferences page; the showcase had none. New showcase_preference object (theme / default landing / email digest / rows-per-page / notifications / density) with one seeded singleton, and a record page (showcase_settings) that groups it into Appearance / Notifications sections. record:details is inline-editable, so it is a working preferences surface — click a value to change it. Reached via Pages → Settings. Browser-verified (:5181): the seeded preferences render in both sections (Theme Light, Default landing My Work, Rows 50, Digest Daily, notifications on) and are inline-editable. typecheck + 20 showcase tests pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
os-zhuang
added a commit
that referenced
this pull request
Jun 29, 2026
fix(core): ADR-0079 — one record-title resolver, stop rendering "Untitled" (#2061) objectui@a4dec79e37c95504b80243d42bf9a3a93758cbd5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The last of the selected enterprise surfaces (after #2059 and #2060). Every enterprise app needs a settings/preferences page; the showcase had none.
What
showcase_preferenceobject — theme / default landing / email digest / rows-per-page / notifications / density — with one seeded singleton ("My Preferences").showcase_settingsrecord page grouping it into Appearance / Notifications sections.record:detailsis inline-editable, so it's a working preferences surface (click a value to change it).Verification
Browser-verified on
:5181: the seeded preferences render in both sections (Theme = Light, Default landing = My Work, Rows = 50, Digest = Daily, notifications on) and are inline-editable.typecheck+ 20 showcase tests pass.This completes the enterprise-surfaces set: Delivery Operations dashboard, Account 360, My Work home, Approvals queue, New Project wizard, and Settings.
🤖 Generated with Claude Code