chore(client): remove dead projects.* env-member SDK methods (ADR-0024 D9)#2332
Merged
Merged
Conversation
…4 D9)
The four projects.{listMembers,addMember,updateMemberRole,removeMember} methods called GET/POST/PATCH/DELETE /cloud/environments/:id/members, which were deleted in cloud#533 (retiring sys_environment_member); they returned 404. Org membership/invites now flow through the better-auth organization plugin (organization.inviteMember/listMembers/…); objectui already uses organization.* and no in-repo callers remained.
The membership field on projects.get() is unchanged — cloud#533 still returns it on the single-env GET (re-sourced to the caller's org sys_member role), so cli environments/show.ts still works.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
documentation
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 10 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the four dead
projects.*env-member methods from the@objectstack/clientSDK:projects.listMembers(id)→GET /api/v1/cloud/environments/:id/membersprojects.addMember(id, payload)→POST …/membersprojects.updateMemberRole(id, memberId, role)→PATCH …/members/:memberIdprojects.removeMember(id, memberId)→DELETE …/members/:memberIdWhy
These control-plane endpoints were deleted in cloud#533 (retiring
sys_environment_member, ADR-0024 D9), so the methods now return 404. Org membership/invites flow through the better-authorganizationplugin (organization.inviteMember/listMembers/…). objectui already usesorganization.*, and there are no in-repo callers of the removed methods.This is the framework-side follow-up explicitly called out in cloud#533's PR description.
Kept (intentionally)
membership?: anyfield onprojects.get()— cloud#533 still returns it on the single-env GET (re-sourced to the caller's orgsys_memberrole), sopackages/cli/src/commands/environments/show.ts(res?.membership?.role) is unchanged.organization.*andorganization.teams.*member methods (better-auth) — untouched.Verification
turbo run build --filter=@objectstack/client: ✅ (DTS clean)tsc --noEmit: ✅ clean@objectstack/clienttests: ✅ 106 passed (106)Changeset:
patch(removing dead, zero-caller methods;@objectstack/clientis in the platformfixedversion group).🤖 Generated with Claude Code