fix(app-showcase): drop wrong-context userFilters from showcase_task.tabular + reclassify P0-30#2564
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
documentation
…tabular (#2563) objectui ADR-0053 reserves userFilters for page lists ("filters" mode); on an object list view ("views" mode) the console suppresses them by design — a showcase view demoing a field the console is designed to ignore is actively misleading (it's how dogfood finding P0-30 got filed). Point the comment at the ADR split instead: named views on the object, userFilters in the task-workbench/task-triage/active-projects page examples. Also reclassify P0-30 in the test report (by-design suppression; the silent drop is fixed by objectui#2220) and mark P0-29 fixed upstream (objectui#2218). Fixes #2563 Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2563
What
Dogfood finding P0-30 ("view
userFiltersquick filters don't render at all") was investigated against objectui source and is by design, not a rendering bug: objectui ADR-0053 reservesuserFiltersfor page lists (InterfaceListPage, "filters" mode); on an object list view ("views" mode) the console suppresses them — the view switcher is the only nav control there. The real defects were:showcase_task.tabulardefineduserFiltersunder a stale ADR-0047 comment, while the same file's header already states the ADR-0053 rule and the page examples (task-workbench/task-triage/active-projects) demo the correct usage.Changes
examples/app-showcase/src/views/task.view.ts— remove theuserFiltersblock from thetabularview; comment now points at the ADR-0053 split (named views on the object,userFiltersin the page examples).examples/app-showcase/docs/test/console-list-form-capability-report-2026-07.md— reclassify P0-30 (by-design suppression + silent-drop DX gap + wrong-context metadata) and mark P0-29 fixed upstream (objectui#2218).Verification
Against the running showcase dev stack (port 3777):
/api/v1/meta/app?id=showcase_appand/api/v1/meta/objects/showcase_taskcontain zerouserFiltersoccurrences after the change;showcase_task.tabularrenders its own columns/tab correctly, no ADR-0053 suppression warning on a clean load.🤖 Generated with Claude Code