Skip to content

Fix TypeScript error: make LoggerConfig.name optional #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hotlong merged 2 commits into from
Jan 30, 2026
Merged

Fix TypeScript error: make LoggerConfig.name optional #405

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7a34f0
Initial plan
Copilot Jan 30, 2026
e5e8e95
Fix TypeScript compilation error in logger by making 'name' field opt…
Copilot Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/core/src/logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import type { Logger } from './contracts/logger.js';
* - Distributed tracing support (traceId, spanId)
*/
export class ObjectLogger implements Logger {
private config: Required<Omit<LoggerConfig, 'file' | 'rotation'>> & { file?: string; rotation?: { maxSize: string; maxFiles: number } };
private config: Required<Omit<LoggerConfig, 'file' | 'rotation' | 'name'>> & { file?: string; rotation?: { maxSize: string; maxFiles: number }; name?: string };
private isNode: boolean;
private pinoLogger?: any; // Pino logger instance for Node.js
private pinoInstance?: any; // Base Pino instance for creating child loggers
Expand All @@ -32,6 +32,7 @@ export class ObjectLogger implements Logger {
format: config.format ?? (this.isNode ? 'json' : 'pretty'),
redact: config.redact ?? ['password', 'token', 'secret', 'key'],
sourceLocation: config.sourceLocation ?? false,
name: config.name,
file: config.file,
rotation: config.rotation ?? {
maxSize: '10m',
Expand Down Expand Up @@ -64,6 +65,11 @@ export class ObjectLogger implements Logger {
}
};

// Add name if provided
if (this.config.name) {
pinoOptions.name = this.config.name;
}

// Transport configuration for pretty printing or file output
const targets: any[] = [];

Expand Down
Loading