Skip to content

Fix duplicate property in logger config object#408

Merged
hotlong merged 2 commits into
mainfrom
copilot/update-job-group-steps
Jan 30, 2026
Merged

Fix duplicate property in logger config object#408
hotlong merged 2 commits into
mainfrom
copilot/update-job-group-steps

Conversation

Copilot AI commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

TypeScript compilation was failing with TS1117: An object literal cannot have multiple properties with the same name in packages/core/src/logger.ts.

Changes

  • Removed duplicate name property assignment in ObjectLogger constructor config initialization (line 36)

The config object was setting name: config.name twice - once at line 31 (correct) and again at line 36 (removed).

this.config = {
    name: config.name,
    level: config.level ?? 'info',
    format: config.format ?? (this.isNode ? 'json' : 'pretty'),
    redact: config.redact ?? ['password', 'token', 'secret', 'key'],
    sourceLocation: config.sourceLocation ?? false,
-   name: config.name,  // Duplicate removed
    file: config.file,
    rotation: config.rotation ?? {
        maxSize: '10m',
        maxFiles: 5
    }
};
Original prompt

引用: https://github.com/objectstack-ai/spec/actions/runs/21524624893/job/62024877321#step:8:1


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@vercel

vercel Bot commented Jan 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
spec Ready Ready Preview, Comment Jan 30, 2026 5:34pm

Request Review

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot AI changed the title [WIP] Update job group steps for better clarity Fix duplicate property in logger config object Jan 30, 2026
Copilot AI requested a review from hotlong January 30, 2026 17:35
@hotlong
hotlong marked this pull request as ready for review January 30, 2026 17:47
Copilot AI review requested due to automatic review settings January 30, 2026 17:47
@hotlong
hotlong merged commit fcc8a9f into main Jan 30, 2026
5 checks passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a TypeScript compilation error (TS1117) caused by duplicate name property assignments in the ObjectLogger constructor's config initialization. The duplicate property on line 36 has been removed, leaving the correct assignment on line 31.

Changes:

  • Removed duplicate name: config.name property assignment from the config object initialization in the ObjectLogger constructor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants