Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .changeset/i18n-extract-configs-drop-undeclared-name.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
---
---

chore(i18n): drop the undeclared `name:` key from all nine `scripts/i18n-extract.config.ts`

Releases nothing — build-time-only extract fixtures (`scripts/` is not in any
package's published `files`), no runtime or published behaviour changes.

Every one of the nine extract configs opened its `defineStack({ … })` with a
`name:` that the stack schema does not declare, so `ObjectStackDefinitionSchema`
dropped the value at load and the #4167 unknown-stack-key lint reported it —
once per package, on every `pnpm check:i18n` run, in a run that was otherwise
fully green:

```
defineStack: stack.name: 'name' is not a declared stack key, so its value is dropped at load — did you mean 'pages'?
```

The lint was right and the configs were wrong: nothing has ever read a stack's
top-level `name` — `os i18n extract` receives the *parsed* `defineStack` result,
from which the key is already gone — so the nine values were inert. The fix is
at the producer (#4736 decision A: delete the nine keys), not a new authorable
key in `packages/spec` to accommodate one typo copied nine times.

Extraction output is unchanged: after the deletion a full
`node scripts/check-i18n-bundles.mjs --write` regenerates all 40 bundles across
the nine packages with a byte-identical result, and `pnpm check:i18n` stays
green — now without the warning.
2 changes: 0 additions & 2 deletions packages/platform-objects/scripts/i18n-extract.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,6 @@ import { jaJP } from '../src/apps/translations/ja-JP.js';
import { esES } from '../src/apps/translations/es-ES.js';

export default defineStack({
name: 'platform-objects-i18n-extract',

objects: [
// Identity
SysUser,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ import { jaJPObjects } from '../src/translations/ja-JP.objects.generated.js';
import { esESObjects } from '../src/translations/es-ES.objects.generated.js';

export default defineStack({
name: 'plugin-approvals-i18n-extract',
objects: [SysApprovalRequest, SysApprovalAction, SysApprovalDelegation] as any,
translations: [
{ en: { objects: enObjects } },
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import { jaJPObjects } from '../src/translations/ja-JP.objects.generated.js';
import { esESObjects } from '../src/translations/es-ES.objects.generated.js';

export default defineStack({
name: 'plugin-audit-i18n-extract',
objects: [SysAuditLog, SysActivity, SysComment] as any,
translations: [
{ en: { objects: enObjects } },
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import { jaJPObjects } from '../src/translations/ja-JP.objects.generated.js';
import { esESObjects } from '../src/translations/es-ES.objects.generated.js';

export default defineStack({
name: 'plugin-security-i18n-extract',
objects: [SysPosition, SysCapability, SysPermissionSet, SysUserPermissionSet, SysPositionPermissionSet, SysUserPosition] as any,
translations: [
{ en: { objects: enObjects } },
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import { jaJPObjects } from '../src/translations/ja-JP.objects.generated.js';
import { esESObjects } from '../src/translations/es-ES.objects.generated.js';

export default defineStack({
name: 'plugin-sharing-i18n-extract',
objects: [SysRecordShare, SysSharingRule, SysShareLink] as any,
translations: [
{ en: { objects: enObjects } },
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import { jaJPObjects } from '../src/translations/ja-JP.objects.generated.js';
import { esESObjects } from '../src/translations/es-ES.objects.generated.js';

export default defineStack({
name: 'plugin-webhooks-i18n-extract',
objects: [SysWebhook] as any,
translations: [
{ en: { objects: enObjects } },
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ import { jaJPObjects } from '../src/translations/ja-JP.objects.generated.js';
import { esESObjects } from '../src/translations/es-ES.objects.generated.js';

export default defineStack({
name: 'service-messaging-i18n-extract',
objects: [
InboxMessage,
NotificationReceipt,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import { jaJPObjects } from '../src/translations/ja-JP.objects.generated.js';
import { esESObjects } from '../src/translations/es-ES.objects.generated.js';

export default defineStack({
name: 'service-realtime-i18n-extract',
objects: [SysPresence] as any,
translations: [
{ en: { objects: enObjects } },
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import { jaJPObjects } from '../src/translations/ja-JP.objects.generated.js';
import { esESObjects } from '../src/translations/es-ES.objects.generated.js';

export default defineStack({
name: 'service-storage-i18n-extract',
objects: [SystemFile, SystemUploadSession] as any,
translations: [
{ en: { objects: enObjects } },
Expand Down
Loading