fix: make manifest optional in defineStack to prevent white screen on Vercel#663
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
… white screen on Vercel deploy Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix missing manifest property in deployment
fix: make manifest optional in defineStack to prevent white screen on Vercel
Feb 13, 2026
hotlong
marked this pull request as ready for review
February 13, 2026 14:36
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents defineStack() from failing validation at boot when a stack config omits manifest, which can otherwise lead to a blank/white screen (e.g., in Vercel) after strict defaulted to true.
Changes:
- Make
manifestoptional inObjectStackDefinitionSchema. - Update schema tests to reflect that
manifestis no longer required. - Add a
defineStack()test case to cover manifest-less configs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/spec/src/stack.zod.ts | Loosens the stack definition schema by making manifest optional to avoid strict-mode boot failures. |
| packages/spec/src/stack.test.ts | Updates/extends tests to validate manifest-less schema parsing and defineStack() behavior. |
| { name: 'task', fields: { title: { type: 'text' } } }, | ||
| ], | ||
| }; | ||
| const result = defineStack(config as any); |
There was a problem hiding this comment.
defineStack now accepts configs without manifest, and this config shape matches other tests in this file, so the as any cast is likely unnecessary. Keeping the test type-safe would better catch schema/type regressions (e.g., defineStack(config) without casting).
Suggested change
| const result = defineStack(config as any); | |
| const result = defineStack(config); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
defineStack()throwsmanifest: Required property 'manifest' is missingat boot, causing a white screen. This regressed whenstrictdefaulted totrue— any config without an explicitmanifest(e.g.apps/studio/objectstack.config.ts) now fails validation before the app renders.Changes
packages/spec/src/stack.zod.ts: Makemanifestoptional inObjectStackDefinitionSchema, consistent with every other field in the schemapackages/spec/src/stack.test.ts: Update assertion and add coverage for manifest-lessdefineStack()calls💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.