fix(lint): correct stale two-agent docblock over PLATFORM_AGENT_NAMES - #7184
Conversation
The comment above PLATFORM_AGENT_NAMES said "The two platform agent ids" while the set holds four entries. Per the cloud-side reading in issue #7088's thread, the kernel does ship exactly two platform agents (ask, build); data_chat and metadata_assistant are registered legacy aliases (metadata_assistant -> build, data_chat -> ask) via the cloud alias registry, not agents themselves. The four-member set is behaviorally correct as a reserved-names set — declaring an alias name shadows the platform record through the alias registry, which is exactly what this gate is meant to catch. Only the docblock was wrong; this is a prose-only fix with no behavior change. Fixes #7088
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
📓 Docs Drift CheckThis PR changes 1 package(s): 2 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
⛔ 1 release-owned page(s) also reference the affected code. These are read-only:
|
Fixes #7088
What was wrong
packages/lint/src/validate-ai-agent-authoring.ts:65carried a docblock reading "The two platform agent ids" directly above the four-memberPLATFORM_AGENT_NAMESset (:69):What settled this
Per the cloud-side reading in #7088's thread (measured on cloud
origin/main@485cbd3):What changed
Prose-only fix in one file: the docblock above
PLATFORM_AGENT_NAMESnow says the set holds the two platform agent ids plus their two legacy aliases, and explains why declaring any of the four names is caught by this gate.PLATFORM_AGENT_NAMESitself, the gate logic, and its messages are untouched — no behavior change.Out of scope per the ruling on this card:
packages/spec/src/stack.zod.ts(a different seat's surface — the optional alias cross-reference note there is reported in the dispatch report for the PM to route) andpackages/mcp/src/mcp-server-runtime.ts:445(not evaluated here).Tests
pnpm --filter '@objectstack/lint^...' build— dependency closure builds clean.pnpm --workspace-concurrency=2 --filter @objectstack/lint test -- --maxWorkers=2— 68 test files, 1771 passed, 4 skipped, 0 failed.pnpm --workspace-concurrency=2 --filter @objectstack/lint typecheck— clean.node scripts/check-nul-bytes.mjs— clean.No changeset: comment-only change, releases nothing.
Generated by Claude Code