Skip to content

docs(spec-tooling): fix stale envelope-attribution claim in check-driver-conformance - #7228

Merged
os-help merged 1 commit into
mainfrom
claude/issue-7159-conformance-envelope-attribution
Aug 10, 2026
Merged

docs(spec-tooling): fix stale envelope-attribution claim in check-driver-conformance#7228
os-help merged 1 commit into
mainfrom
claude/issue-7159-conformance-envelope-attribution

Conversation

@os-help

@os-help os-help commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Fixes #7159

What

scripts/check-driver-conformance.mjs, FILTER_TEXT requirement 3's comment block claimed driver-mongodb's default: arm was "the last place a bare new Error escaped the ADR-0112 envelope" — a repo-wide claim. It was already false when written (objectql's having face had two bare new Error returns escaping the same envelope, per #6993's census), and after #7047 (edb4af099, merged via PR #7161, confirmed on origin/main in this branch's ancestry) the claim became true but misattributedhaving, not driver-mongodb, was the actual last site.

Fix

Scoped the clause to the DRIVER family — checkable against this gate's own case-set (the five driver refusals FILTER_TEXT requirement 3 covers) rather than a repo-wide sweep that can go stale the next time a new face is added. Kept the trailing note (per the issue's own argument) that having sat outside this gate's scope (packages/drivers/*), since that gap is the reason two consecutive defects on that face (#5905, #7047) were found by hand-run censuses instead of CI.

Diff:

-//      `code` half the case-set requires and the last place a bare `new Error`
-//      escaped the ADR-0112 envelope.
+//      `code` half the case-set requires and the last bare `new Error` in the
+//      DRIVER family (this gate's own scope, `packages/drivers/*`). The sixth
+//      refusal face — objectql's `having` (`having-filter.ts`) — was outside
+//      that scope and kept its bare `new Error` until #7047.

Prose-only, one file, no case-set/gate-logic/exit-code change.

Durability of the fix

The card's own test for this class of bug: will the corrected sentence still be accurate, or visibly wrong, after the next face is added? The new claim is scoped to "last bare new Error in the DRIVER family (this gate's own scope)" — that's checkable directly against the FILTER_TEXT requirement-3 case-set this comment sits inside, so a future driver face regressing would be a claim about the same five-driver scope the gate already enumerates, not an unscoped repo sweep. It can still go stale if a sixth driver is added and its refusal predates the DRIVER-family claim without anyone re-auditing — same failure shape as this issue, one level narrower — so this is "checkable / narrower blast radius" rather than "provably permanent."

Verification

$ pnpm check:driver-conformance
OK  self-test: detects driven / unused / re-declared fixtures, discovers both axes, ...
...
check-driver-conformance: OK — 36 covered cell(s), 4 in the DEBT ledger, 0 exempt.

Both the --self-test half and the real check pass unchanged — no case-set or DEBT-ledger count moved.

$ node scripts/check-nul-bytes.mjs
check-nul-bytes: OK (scanned 6620 text file(s) ...; no raw ASCII control bytes).

Out of scope

Left all other prose in this file untouched, including any other comment blocks noticed in passing, per this card's scope fence.


Generated by Claude Code

… FILTER_TEXT req 3

driver-mongodb's INVALID_FILTER arm was never "the last place a bare
new Error escaped the ADR-0112 envelope" repo-wide -- objectql's having
face (having-filter.ts) had two bare new Error returns escaping the same
envelope until #7047 (edb4af0, PR #7161) closed them. Scope the claim to
the DRIVER family (this gate's own case-set), which is checkable against
the five driver refusals it actually covers, and keep the trailing note
that having sat outside this gate's scope -- that gap is why two
consecutive defects on that face (#5905, #7047) were found by hand-run
censuses instead of CI.

Prose-only change to one comment block; no case-set, gate logic, or exit
code touched. --self-test and the real check both stay green.

Fixes #7159
@vercel

vercel Bot commented Aug 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectstack Ignored Ignored Aug 10, 2026 3:17am

Request Review

@os-help os-help added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Aug 10, 2026 — with Claude
@os-help
os-help marked this pull request as ready for review August 10, 2026 03:31
@os-help
os-help added this pull request to the merge queue Aug 10, 2026
Merged via the queue into main with commit ef85bbc Aug 10, 2026
24 checks passed
@os-help
os-help deleted the claude/issue-7159-conformance-envelope-attribution branch August 10, 2026 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs skip-changeset PR has no user-facing published change; bypasses the changeset gate

Projects

None yet

2 participants