docs(spec-tooling): fix stale envelope-attribution claim in check-driver-conformance - #7228
Merged
Merged
Conversation
… FILTER_TEXT req 3 driver-mongodb's INVALID_FILTER arm was never "the last place a bare new Error escaped the ADR-0112 envelope" repo-wide -- objectql's having face (having-filter.ts) had two bare new Error returns escaping the same envelope until #7047 (edb4af0, PR #7161) closed them. Scope the claim to the DRIVER family (this gate's own case-set), which is checkable against the five driver refusals it actually covers, and keep the trailing note that having sat outside this gate's scope -- that gap is why two consecutive defects on that face (#5905, #7047) were found by hand-run censuses instead of CI. Prose-only change to one comment block; no case-set, gate logic, or exit code touched. --self-test and the real check both stay green. Fixes #7159
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This was referenced Aug 10, 2026
os-help
marked this pull request as ready for review
August 10, 2026 03:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7159
What
scripts/check-driver-conformance.mjs, FILTER_TEXT requirement 3's comment block claimed driver-mongodb'sdefault:arm was "the last place a barenew Errorescaped the ADR-0112 envelope" — a repo-wide claim. It was already false when written (objectql'shavingface had two barenew Errorreturns escaping the same envelope, per #6993's census), and after #7047 (edb4af099, merged via PR #7161, confirmed onorigin/mainin this branch's ancestry) the claim became true but misattributed —having, not driver-mongodb, was the actual last site.Fix
Scoped the clause to the DRIVER family — checkable against this gate's own case-set (the five driver refusals FILTER_TEXT requirement 3 covers) rather than a repo-wide sweep that can go stale the next time a new face is added. Kept the trailing note (per the issue's own argument) that
havingsat outside this gate's scope (packages/drivers/*), since that gap is the reason two consecutive defects on that face (#5905, #7047) were found by hand-run censuses instead of CI.Diff:
Prose-only, one file, no case-set/gate-logic/exit-code change.
Durability of the fix
The card's own test for this class of bug: will the corrected sentence still be accurate, or visibly wrong, after the next face is added? The new claim is scoped to "last bare
new Errorin the DRIVER family (this gate's own scope)" — that's checkable directly against the FILTER_TEXT requirement-3 case-set this comment sits inside, so a future driver face regressing would be a claim about the same five-driver scope the gate already enumerates, not an unscoped repo sweep. It can still go stale if a sixth driver is added and its refusal predates the DRIVER-family claim without anyone re-auditing — same failure shape as this issue, one level narrower — so this is "checkable / narrower blast radius" rather than "provably permanent."Verification
Both the
--self-testhalf and the real check pass unchanged — no case-set or DEBT-ledger count moved.Out of scope
Left all other prose in this file untouched, including any other comment blocks noticed in passing, per this card's scope fence.
Generated by Claude Code