chore: pin the console to objectui main 8aad9fd50b16 (approvals inbox + bell-badge breakdown) - #7308
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
os-zhuang
marked this pull request as ready for review
August 10, 2026 06:29
This was referenced Aug 10, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7268
Moves the console pin from
09987b680d53to8aad9fd50b16— objectuiorigin/mainHEAD at run time, per the maintainer directive of 2026-08-10 (chat), verbatim: 「直接 pin 到最新」. The target was not narrowed to the two #7213-train PRs the card was filed for.What the range actually carries
09987b680d53...8aad9fd50b16— 67 non-merge commits, of which:majorminorper objectui's launch-window ban onmajor)Resolved bump level:
minorfor@objectstack/console.CONSOLE_BUMPwas not set — the level is whatobjectui-changeset-digest.mjsderived from the highest level objectui itself declared over the range (#4731). It did not come outmajor: the single breaking change is an author annotation in aminorchangeset, not a declaredmajor, and that distinction is reported by the generator rather than inferred here.The one breaking entry, for the release record
objectui
65bb513dc— "fields: remove the docs-demo registration path (registerFields+createFieldRenderer), and host the docs field examples in a real form" (objectui#3910 / #3953, ruling B of objectui#3798). It removes two public TypeScript exports from the@object-ui/fieldsnpm package; the only caller was objectui's own documentation site.The 6 commits with no changeset are itemized by subject inside the changeset body rather than counted, per objectstack#6174 — they ship inside this pin but appear in no objectui CHANGELOG.
ADR-0087 disposition — answered, not left as the placeholder
The generator emits
adr-0087: TODOwhenever the range declares a breaking change and refuses to answer it itself (objectstack#6494). It is answered in the changeset as:not-required (no-migration-prescription)Reasoning, verified rather than assumed:
@objectstack/consolepublishes a frozen prebuilt SPA —files: ["dist", …]and its soleexportsentry is./package.json, so it forwards no@object-ui/fieldsmodule entry point and neither removed export is reachable through this package. Nopackages/specschema, authorable metadata key or protocol surface changes in the range, so there is nothing forobjectstack migrate metato prescribe and no ledger entry to write or to name. The retired-key items elsewhere in the list run the other way — objectui ceasing to author keys ObjectStack already retired and registered in its own PRs (rowLevelSecurity[].priorityvia #7130, theactionUrlwidget key,page:card'sbodyslot). This PR adds no ledger entry and claims none.Why this bump, end to end
28c38567b) registers theapprovals:inboxcomponent-registry key and de-hardcodes Home's approvals entry. With the pin forward, the bundled console carries that registration, so [approvals] Point the account app's Approvals nav at the inbox component; contribute a Setup inbox entry; document mounting the inbox in business apps #7234's{ type: 'component', componentRef: 'approvals:inbox' }nav metadata (PR feat(approvals): point the account app's Approvals nav at the inbox component (#7234) #7298) resolves instead of rendering the component-not-found empty state. That is the [approvals][console] 「待我审批」有三个并存入口、三套不同 UI —— 其中 sys_approval_request 原生视图是无决策动作的开发者原始表 #7213 epic's end-to-end acceptance.8c60819a6) adds the bell-badge notifications + approvals breakdown in the inbox popover.Both were already merged upstream; the pin was the only thing holding their behavior out of the bundled console.
Verification
The declaration-parity ratchet reports no drift — the 62 spec-only divergences are the accepted baseline, unchanged by this pin.
Notes for the reviewer
Three things came out differently from what the card anticipated. All three are reported rather than smoothed over:
bump-objectui.shwith no sha defaults to the current HEAD of../objectui, and in this container that checkout sat at0a09793f2— a strict ancestor oforigin/main, 11 commits behind, i.e. 56 of the 67 commits in the range. The directive is pin to latest, so the sha was resolved explicitly fromorigin/mainafter fetching and passed as an argument.check:objectui-pin-freshthen confirms mechanically that the landed pin is objectuimain.pnpm-lock.yamlplus the hono override; this range produced neither. The diff is exactly two files.origin/mainwas still merged in before opening this PR anyway, per the lockfile-contention rule.--depth=250) until09987b68..origin/mainwalked, and the digest is the derived article, not the degraded tip-subject fallback — the artifact says so in its own accounting footer.Diff surface
.objectui-shaand.changeset/console-8aad9fd50b16.md. Nothing else — no riders.packages/console/dist/is gitignored and generated, and is confirmed absent from the diff; the changeset is the one the bump script emitted, not a hand-written second one.Generated by Claude Code