fix: resolve CI type-check and DTS build errors#782
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…ng type - Remove unused imports UpgradePackageResponseSchema/RollbackPackageResponseSchema from package-api.zod.ts - Fix Manifest -> ObjectStackManifest type import in package-service.ts - Rename DependencyResolutionResultSchema in plugin-versioning.zod.ts to PluginDependencyResolutionResultSchema to resolve duplicate export conflict - Update plugin-versioning.test.ts for renamed schema Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CI errors in build process
fix: resolve CI type-check and DTS build errors
Feb 22, 2026
hotlong
marked this pull request as ready for review
February 22, 2026 03:07
Contributor
There was a problem hiding this comment.
Pull request overview
Resolves TypeScript CI failures in packages/spec by removing duplicate symbol exports and fixing incorrect/unused imports in protocol schemas and contracts.
Changes:
- Renamed the plugin-scoped dependency resolution schema/type in
plugin-versioning.zod.tsto avoid a duplicate export collision withdependency-resolution.zod.ts. - Fixed
package-service.tsto import and use the correct manifest type (ObjectStackManifest). - Removed unused schema imports from
package-api.zod.tsand updated the corresponding test to use the renamed schema.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/spec/src/kernel/plugin-versioning.zod.ts | Renames dependency resolution result schema/type to prevent duplicate exports. |
| packages/spec/src/kernel/plugin-versioning.test.ts | Updates tests to reference the renamed schema. |
| packages/spec/src/contracts/package-service.ts | Replaces nonexistent Manifest type import with ObjectStackManifest. |
| packages/spec/src/api/package-api.zod.ts | Removes unused imports from package-upgrade.zod to satisfy TS unused-import checks. |
| * Result of dependency resolution process | ||
| */ | ||
| export const DependencyResolutionResultSchema = z.object({ | ||
| export const PluginDependencyResolutionResultSchema = z.object({ |
There was a problem hiding this comment.
PluginDependencyResolutionResultSchema is missing a top-level .describe(...) annotation, which the repo generally uses to support JSON Schema/docs generation (e.g. packages/spec/src/kernel/dependency-resolution.zod.ts:106-127). Consider adding a .describe('Plugin dependency resolution result') (and optionally .describe(...) on the remaining fields) to keep documentation output consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four TypeScript errors breaking CI on
main: duplicate exports inkernel/index.ts, unused imports, and a nonexistent type import.Duplicate export conflict (TS2308): Both
dependency-resolution.zod.tsandplugin-versioning.zod.tsexportDependencyResolutionResultSchema/DependencyResolutionResult. Renamed the plugin-versioning variants toPluginDependencyResolutionResultSchema/PluginDependencyResolutionResultsince they're structurally different schemas (plugin-scoped vs package-lifecycle).Missing type export (TS2305):
package-service.tsimportedManifestfrommanifest.zod.ts, which actually exportsObjectStackManifest. Fixed all references.Unused imports (TS6133): Removed
UpgradePackageResponseSchemaandRollbackPackageResponseSchemafrompackage-api.zod.ts.Test updates: Updated
plugin-versioning.test.tsto reference the renamed schema.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.