Skip to content

fix: add missing pinned/starred fields to in-memory feed adapter #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hotlong merged 2 commits into from
Feb 22, 2026
Merged

fix: add missing pinned/starred fields to in-memory feed adapter #784

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
755b8f0
Initial plan
Copilot Feb 22, 2026
63e3a86
fix: add missing pinned/starred fields to in-memory-feed-adapter
Copilot Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/services/service-feed/src/in-memory-feed-adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,8 @@ export class InMemoryFeedAdapter implements IFeedService {
visibility: input.visibility ?? 'public',
replyCount: 0,
isEdited: false,
pinned: false,
starred: false,
Comment on lines +150 to +151

Copilot AI Feb 22, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test 'should create a feed item and return it' verifies other default fields (visibility, replyCount, isEdited) but doesn't verify the newly added pinned and starred fields. Consider adding assertions to check that item.pinned is false and item.starred is false to ensure these default values are properly set.

Copilot uses AI. Check for mistakes.
createdAt: now,
};

Expand Down