fix(pm): add per-file ceilings for the four uncovered skills - #9535
Merged
Conversation
The skill line ratchet's header claims "the ceiling now covers the whole surface, per file" but the CEILINGS map only held the pm-dispatch surface. Add entries for checklist-test, checklist-author, dogfood-verification, and spec-property-retirement at their current line counts on origin/main (headroom 0, same convention as the existing entries). Extend the script's own self-test to assert the four are covered. Fixes #9473
os-support-ai
added
skip-changeset
Claude
os-support-ai
marked this pull request as ready for review
August 18, 2026 08:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9473
What
scripts/pm/check-skill-line-ratchet.mjs's header claims "the ceiling now covers the whole surface, per file", but theCEILINGSmap only held the pm-dispatch surface (SKILL.md + 5 references +os-dev.md). Adds four entries at their current line counts on fetchedorigin/main(headroom 0, same shrink-only convention as the existing entries):.claude/skills/checklist-test/SKILL.md— 232.claude/skills/checklist-author/SKILL.md— 61.claude/skills/dogfood-verification/SKILL.md— 155.claude/skills/spec-property-retirement/SKILL.md— 328No instruction-text changes; only
scripts/pm/check-skill-line-ratchet.mjstouched, per the card's file-surface constraint.This is a pure extension of an existing guard in its own declared direction (no ceiling raised or loosened), so the maintainer-ruling requirement for raising a ceiling does not apply here.
Self-test
Extended the script's existing
--self-testfixtures with one new case asserting the four files are covered, matching the convention already used for the pm-dispatch entries ('SKILL.md is covered','all five compressed references are covered', etc.). No new test harness invented.Verification (head
79b0f2a)node scripts/pm/dispatch-gates.mjs(no path args, derived from merge-base02ebb6f5b) names exactly one local gate for this diff:pnpm check:pm-skill-ratchet— run above, exit 0.node scripts/check-nul-bytes.mjsalso clean (edited file only).This diff publishes nothing (internal PM guard tooling only) —
skip-changesetlabel applied.Generated by Claude Code
Generated by Claude Code