finding(components): the action renderers declare the deprecated `ActionSchema` but are written against `UIActionSchema`

[yinlianghui]

Found while typing the action renderers for #4353 (PR #4417). Observation-class: nothing a user hits today, no fix proposed here. Unexercised drift — the contradiction was unverifiable until noImplicitAny went on, because the props type never reached the code that reads it (see the sibling finding on the PropsWithoutRef collapse).

What

@object-ui/types exports two action types:

• ActionSchema — from crud.ts, carrying its own @deprecated Use UIActionSchema ... for new code
• UIActionSchema — from ui-action.ts, exported under that alias, the modern one

action-bar.tsx, action-menu.tsx and action-group.tsx import the legacy one and declare their authoring keys with it:

export interface ActionBarSchema {
  actions?: ActionSchema[];        // legacy
  systemActions?: ActionSchema[];  // legacy
}

…while the code underneath is written against the modern one. Three independent proofs, each a compiler error the moment the legacy type is actually applied to those values (all four observed on the #4353 branch before the annotations were switched):

what the code does	why legacy ActionSchema cannot be it
actionRendersAt(a, schema.location) — the shared placement predicate, which takes { locations?: readonly string[] }	legacy has no locations at all → TS2559 (weak-type detection), in action-bar and action-group
the objectui#2339 ordering tie-break, a.variant === 'primary'	legacy variant is 'default' | 'outline' | 'ghost' | 'link' → TS2367, three times
every handoff to a leaf (InlineActionButton, DropdownActionItem, ActionMenuItem, ActionAutoTrigger)	legacy type is the literal 'action'; the values carry 'form' | 'script' | 'url' | 'flow' | 'api' | 'modal' → TS2322

action-bar.tsx's own documented example, at the top of the file, is a UIActionSchema (type: 'script'). And action-group.tsx / action-menu.tsx already carry (action.variant as string) casts that exist for no other reason than to get around the legacy union.

Why it was invisible

schema never arrived typed. These are forwardRef components whose props type carries [key: string]: any, and forwardRef routes props through PropsWithoutRef, whose Omit collapses such a type to the bare index signature — so schema was any, schema.actions was any, and the declaration above was never compared against anything. Filed separately as the mechanism.

What #4417 did and did not do

PR #4417 typed the implementation from UIActionSchema — that is what the values are — and left the actions?: ActionSchema[] declarations on the legacy type, naming the mismatch in a comment at each site. Reconciling the declarations reaches roughly 46 ActionSchema references across 12 files in this package, and it is a contract decision rather than a consequence of turning a compiler flag on:

• do the three action:* schema interfaces publish the modern action type (and every consumer constructing one moves with them), or
• is the legacy type genuinely the authoring contract here, in which case the implementation is reading keys the contract does not grant?

Neither of those is settled by #4353's ruling, which is why #4417 stopped at the boundary.

Notes

• None of the three interfaces, nor the leaf components, is re-exported from packages/components/src/index.ts, so no published declaration is involved either way — this is an internal-consistency question, not a breaking-change question.
• The deprecation on crud.ts's ActionSchema says the interface "will be removed in a future major version", so the drift resolves itself destructively if nobody decides first.

---

Generated by Claude Code

[yinlianghui]

CLAIM (pair) + RULINGS — PM seat session_017Qqyix2QcnpUC9XeYVDzx3, one dev agent for #4418 + #4422 (same action-renderer files — running them separately would race), branch claude/issue-4418-4422-action-typing-integrity, one PR, Fixes #4418 + Fixes #4422.

Rulings (delegated, veto window open):

• finding(components): the action renderers declare the deprecated ActionSchema but are written against UIActionSchema #4418 — converge on UIActionSchema. PR feat(components): compile under noImplicitAny — type the 26 renderer signatures + 2 test sites #4417's four compiler proofs establish the VALUES are the modern type; the legacy ActionSchema is self-declared @deprecated. The exported actions?: ActionSchema[] keys on the three schema interfaces (and the ~46 refs behind them) migrate to UIActionSchema. Published-type change → minor with the breaking semantics in the body (fix(i18n): retire the reader-less common.search key from the ten locale packs (#4392) #4403 precedent), never major. If the sweep reveals refs whose migration genuinely changes runtime acceptance (a consumer passing legacy-only values), stop that ref and report — the type must not silently reject working metadata.
• finding(components): forwardRef + a props index signature silently erases every declared prop type — 11 renderers affected #4422 — direction 1 plus a guard, staged. Annotate the 11 render functions' parameters directly (the annotation bypasses PropsWithoutRef, restoring the declared types now — and expect it to surface latent errors the way feat(components): compile under noImplicitAny — type the 26 renderer signatures + 2 test sites #4417's retype did; fix what surfaces, honestly scoped). PLUS the mechanical guard the card says the compiler cannot provide: a structural test in the fix(app-shell,data-objectstack): route every view write through one cache invalidation seam #4398-pin style that fails on any forwardRef instantiated with an index-signature props type whose render parameter lacks a direct annotation — so the trap stays closed for the next author. Directions 2/3 (dropping index signatures / shared helper) are deferred: they need per-component prop surfaces and interact with the finding(plugin-dashboard): the #3291 toDomProps whitelist stops at packages/fields — SDUI widgets elsewhere still close their DOM leak by hand, if at all #4425 whitelist question — not this PR.

Dispatch gate: branch only after PRs #4417 AND #4423 (both touching components) are in origin/main — poll.

---

Generated by Claude Code