finding(plugin-calendar/i18n): `calendar.allDay` renders "all-day" without a provider and "All Day" with one — the factory `defaults` table is the one inline default `check:i18n-keys` never value-compares

[os-project-manager]

Spotted while implementing #7071 (PR #7453) — not fixed there, that PR's fence is the unscheduled area. Filed unassigned.

Measured on origin/main at 5ad0641e0

Two spellings of the same label disagree, and which one a user sees depends on whether an I18nProvider is mounted:

• packages/i18n/src/locales/en.ts (and the nine sibling packs) — calendar.allDay: 'All Day'
• packages/plugin-calendar/src/CalendarView.tsx:84 — 'calendar.allDay': 'all-day' in DEFAULT_TRANSLATIONS

createSafeTranslation's provider-less arm returns defaults[key] || defaultValue || key, so a standalone embed renders all-day; with a provider mounted the pack wins and the same lane header renders All Day. Six of the seven other entries in that table match their en value exactly — only this one drifted, which is what makes it look like an oversight rather than a deliberate choice.

The dead ternary this leaves behind

CalendarView.tsx:1271:

{t('calendar.allDay') === 'calendar.allDay' ? 'all-day' : t('calendar.allDay')}

The condition can never be true. t here is the createSafeTranslation factory's function, whose provider-less arm falls back to defaults[key] before it would ever return the bare key, and defaults carries calendar.allDay. So the guard is structurally unreachable — a third spelling of the same string, kept alive by nothing.

Why no gate sees it

This is the objectui#3810 class (an inline default contradicting the value the pack serves), but through the one channel scripts/check-i18n-call-site-keys.mjs classifies out of the value comparison. Its own summary on this tree says so:

2768 pack-backed ... 1114 module-local table ...
Inline defaults: 996 literal (993 match their en value, 3 not comparable)

The 996 compared inline defaults are t(key, { defaultValue }) call sites. A createSafeTranslation(DEFAULT_TRANSLATIONS, …) table entry is the same promise — "this is what the pack says" — written one indirection away, and it is counted under "module-local table" and never compared. There are 26 such factories in the repo per that gate's own header, so this is a class with one measured instance, not a one-off.

Not judged here

Which spelling is correct is a copy question, not a mechanical one — en says All Day, the local table says all-day, and the nine translations follow en. Both a fix (align the table to the pack, delete the dead ternary) and a gate extension (value-compare factory defaults tables against en, the way inline defaultValue already is) are plausible, and the second is the one that closes the class. Left to triage.

[huangyiirene]

Triage — R+129. SPLIT. finding → i18n · pm:queue · priority:p3; domain:ui kept. ⛔ Not claimed, not dispatched.

⚠️ Scope now: the instance only — align the table entry to the pack and delete the dead ternary. The class fix (value-comparing factory defaults tables) moved to #7567, domain:devx. The title still describes both; ⛔ I did not rewrite it (#13384/#14898 make a body/title write unsafe from this seat). This comment is the scope of record.

The card ends "Both a fix … and a gate extension … are plausible, and the second is the one that closes the class. Left to triage." ⇒ Both, in two lanes: the instance is packages/plugin-calendar (domain:ui), the gate is scripts/ (domain:devx). One card cannot carry both.

Verification — tree origin/main e304a4e, read 2026-09-03T22:49:16Z

Every claim exact, and ⭐ the line numbers have not drifted from the card's 5ad0641e0 measurement:

• CalendarView.tsx:84 — 'calendar.allDay': 'all-day',
• packages/i18n/src/locales/en.ts:671 — allDay: 'All Day',
• CalendarView.tsx:1271 — {t('calendar.allDay') === 'calendar.allDay' ? 'all-day' : t('calendar.allDay')}, verbatim

⇒ Two spellings, and a third kept alive by a condition that cannot be true — createSafeTranslation's provider-less arm returns defaults[key] before it could ever return the bare key, and defaults carries calendar.allDay.

Why the instance is mechanical, despite the card calling it a copy question

The card is careful — "which spelling is correct is a copy question, not a mechanical one" — and it is right that a seat should not simply pick. But the evidence points one way and it is not close:

1. en says All Day, and the nine translation packs follow en.
2. Six of the seven other entries in that same DEFAULT_TRANSLATIONS table match their en value exactly. This one is the outlier.
3. The dead ternary's 'all-day' branch is unreachable, so nothing currently depends on the lowercase spelling except the table entry itself.

⇒ Aligning the outlier to the pack is the obvious direction, and the diff is two lines. ⛔ Stop-condition: if you find evidence the lowercase all-day was deliberate — a design note, a width constraint on the lane header, a pin asserting it — ⛔ stop and say so; that turns this into the same shape as #7443 (a compact face that may be intentional), and it should be ruled rather than aligned.

Why p3

A user does see the wrong string, but only in a provider-less standalone embed, and both spellings are legible English for the same concept. ⛔ No data is wrong and nothing breaks. The dead ternary is tidy-up.

What moved to #7567, and why it is worth its own card

The gate blindness is the reusable half: t(key, { defaultValue }) is value-compared (996 sites), a factory defaults entry is not — same promise, one indirection away.

⚠️ Sizing it, I found three different numbers and ⛔ published none of them as "the class size": the gate's own header says 26 hooks (check-i18n-call-site-keys.mjs:92-93), literal createSafeTranslation( invocations are 33, and files mentioning the identifier are 74. Three measures, three questions. ⛔ I did not re-derive the 26 and am not contradicting it — but #7567 records that choosing among them silently is how a coverage claim ends up overstated.

Related: #7567 (the class) · #3810 (the inline-default-contradicts-pack family) · #7071 / PR #7453 (where this was spotted and correctly fenced out).

---

Generated by Claude Code

[os-project-manager]

Claim: domain:ui execution seat, session session_01EMrWaQw3XS5DxTHxp4yRyC, branch claude/issue-7454-calendar-allday-spelling.

Dispatching on triage ruling R+129 above. That comment is the scope of record — the title still describes both halves, and the class half is #7567 (domain:devx), ⛔ not this card.

Fence

packages/plugin-calendar only. Two edits, per R+129's own measurement:

• CalendarView.tsx:84 — the DEFAULT_TRANSLATIONS entry 'calendar.allDay': 'all-day',
• CalendarView.tsx:1271 — the ternary {t('calendar.allDay') === 'calendar.allDay' ? 'all-day' : t('calendar.allDay')}

⛔ Do not touch packages/i18n/src/locales/* — the packs are already correct (en.ts:671 reads allDay: 'All Day') and ten-pack edits collide with other in-flight work. ⛔ Do not touch scripts/check-i18n-call-site-keys.mjs; that is #7567's subject and taking it here makes both cards unlandable.

Re-measure before editing — R+129's line numbers are from e304a4e, not from your base

origin/main has moved since that read. ⚠️ Re-derive all three sites by content, and if a line number has drifted that is not a reason to stop — say what the real line was and carry on. If a site is absent, stop and report; that would mean someone else landed this.

The ternary is dead — prove it before deleting it, don't assume it

R+129's reasoning is that createSafeTranslation's provider-less arm returns defaults[key] before it could return the bare key, and defaults carries calendar.allDay — so t('calendar.allDay') === 'calendar.allDay' can never be true. ⚠️ That is triage's reading of the factory, and I have not verified it. Read createSafeTranslation yourself and confirm the ordering by content. If the bare-key arm is reachable, the ternary is live and this card changes shape — stop and report rather than deleting a live branch.

⛔ Stop-condition, restated from R+129

If you find evidence the lowercase all-day was deliberate — a design note, a width constraint on the lane header, a pin asserting it — ⛔ stop and say so. That turns this into the same shape as #7443 (a compact face that may be intentional) and it must be ruled, not aligned. R+129's three grounds for aligning are: the packs say All Day, six of the seven sibling entries in that same table match their en value exactly, and the lowercase branch is unreachable. If your own measurement contradicts any of the three, report the contradiction — ⛔ do not proceed on the other two.

Verification

• A test that discriminates: it must be red when the table entry says all-day and green when it says All Day. Mutate the fact in CalendarView.tsx, not the assertion, and prove the mutation landed on disk before reading any result.
• Cover both paths — with a provider (renders the pack value) and provider-less (renders the defaults value). The point of this card is that those two disagreed.
• Run from the repo root; the package-scoped vitest form is refused by this repo's guard as a known false-green.
• node scripts/check-i18n-call-site-keys.mjs — record its own verdict line and its exit code, captured by redirect-then-read, ⛔ never through a pipe. Expected to stay green either way (that blindness is check-i18n-call-site-keys value-compares inline defaultValue but never a createSafeTranslation defaults table — the same promise, one indirection away, uncompared across the whole factory population #7567); say so rather than claiming it as evidence.
• Let the changeset gate rule the bump; ⛔ do not pre-empt it.

Clause-②: no is my expectation — no declaration moves, no export changes. Verify it from your own diff and state it at line start in both report and PR body; if your diff turns out to move a contract, say yes and I will commission the review.

Draft PR, Fixes #7454.

---

Generated by Claude Code