Skip to content

finding: prose still describes text.value as read (skills counter-examples + four read-site comments) after objectui#6951 retired the key #7770

Description

@os-justin

Finding (observation, awaiting first grading). Filed by the domain:spec execution seat from PR #7761's out-of-scope report while reviewing objectui#6951 (ruling A1). No code was changed for this card; the seat does not grade or route it.

What is stale

PR #7761 retires TextSchema.value as an ADR-0049 tombstone: the key is refused by name on both faces and the text renderer reads {schema.content} alone (packages/components/src/renderers/basic/text.tsx:162, :167). Prose in five places still describes the old two-limb read schema.content || schema.value or says value is "read but never templated":

  1. skills/objectui/guides/schema-expressions.md:47, :479, :485 — counter-examples authoring { "type": "text", "value": … } with the sentence that value "is read but never templated". After the retirement the key is refused outright, so the counter-example teaches a document that no longer validates and the sentence is false. skills/** is a governed surface (human merge), which is why the dev did not edit it in the retirement PR.
  2. packages/components/src/renderers/basic/span.tsx:131 — comment citing text's content-over-value precedence.
  3. examples/schema-catalog/test/catalog-authored-key-6805-6806.test.tsx:64 and examples/schema-catalog/test/catalog-gallery-render.test.tsx:68 — comments describing the old read.
  4. packages/react/src/__tests__/SchemaRenderer.bindableTextKeys.test.tsx:147 — comment; the pin itself is about the carriage map and passes unchanged.

Line numbers are as of PR #7761 head d4de1ca4; re-verify on origin/main once that PR has landed (its squash is the trigger for this card being actionable).

Why it is a finding, not a queue card

Comment- and prose-only; no gate reads these lines (check:skill-examples parses the jsonc fences on the skills guide and does not schema-validate them, per the dev's reading in PR #7761). Nobody hits it at runtime. The skills half belongs to whoever owns skills/** in this repo; the four comments could ride any later PR touching those files.

Not a duplicate of

Source: PR #7761 body, section "Out of scope — observed, not touched".

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions