Found by the domain:devx @ objectui execution seat while delivering #7310 (PR #8028); out of that card's scope, filed rather than fixed. Observation class: a comment that no longer describes the tree, in a file whose comments are load-bearing.
The claim, and why it is false
packages/i18n/src/__tests__/fallback-placeholder-spelling-3512.test.ts's header, under "Why this file lives in @object-ui/i18n when two of its surfaces do not":
defaults-maps-mirror-en-pack.test.ts had to move to app-shell because it IMPORTS three plugin maps, and every one of those packages depends on this one — importing them back inverts the dependency. This file imports nothing outside its own package: it READS the source files as text and parses them, which is not a module dependency in either direction.
The same file imports @object-ui/test-support/defaults-table-scan, which is outside its own package. That import arrived with objectui#7884, when the defaults-table walk moved into @object-ui/test-support so the objectui#4401 gate and this one would ask their questions of one population — a change the header describes correctly a hundred lines further down, without updating the sentence above it.
Why it is a finding and not nothing
The sentence is not decoration: it is the stated REASON the file is allowed to live in @object-ui/i18n rather than move to app-shell like its sibling. Read as written, it says this file may take no cross-package import — a rule the file itself already breaks, and one the next person deciding "may this suite import X?" would either apply wrongly or quietly ignore. Both outcomes are worse than the sentence being accurate.
Nothing is wrong at runtime, and no gate can see it: the import is legal (a private: true test-support package, in a directory this package's build excludes) and comment accuracy is not mechanically checkable here.
Shape of a fix
Rewrite that one paragraph so the invariant it states is the one that actually holds — the distinction that survives is DIRECTION, not absence: @object-ui/test-support and (since #7310) scripts/placeholder-spelling.mjs-shaped helpers point AWAY from the package's runtime graph and are excluded from its build, whereas the three plugin maps defaults-maps-mirror-en-pack.test.ts needs point back INTO it. One paragraph; no code change; no gate moves.
Refs: PR #8028 (#7310) · objectui#7884 · objectui#4401.
Generated by Claude Code
Found by the
domain:devx@ objectui execution seat while delivering #7310 (PR #8028); out of that card's scope, filed rather than fixed. Observation class: a comment that no longer describes the tree, in a file whose comments are load-bearing.The claim, and why it is false
packages/i18n/src/__tests__/fallback-placeholder-spelling-3512.test.ts's header, under "Why this file lives in@object-ui/i18nwhen two of its surfaces do not":The same file imports
@object-ui/test-support/defaults-table-scan, which is outside its own package. That import arrived with objectui#7884, when the defaults-table walk moved into@object-ui/test-supportso the objectui#4401 gate and this one would ask their questions of one population — a change the header describes correctly a hundred lines further down, without updating the sentence above it.Why it is a finding and not nothing
The sentence is not decoration: it is the stated REASON the file is allowed to live in
@object-ui/i18nrather than move toapp-shelllike its sibling. Read as written, it says this file may take no cross-package import — a rule the file itself already breaks, and one the next person deciding "may this suite import X?" would either apply wrongly or quietly ignore. Both outcomes are worse than the sentence being accurate.Nothing is wrong at runtime, and no gate can see it: the import is legal (a
private: truetest-support package, in a directory this package's build excludes) and comment accuracy is not mechanically checkable here.Shape of a fix
Rewrite that one paragraph so the invariant it states is the one that actually holds — the distinction that survives is DIRECTION, not absence:
@object-ui/test-supportand (since #7310)scripts/placeholder-spelling.mjs-shaped helpers point AWAY from the package's runtime graph and are excluded from its build, whereas the three plugin mapsdefaults-maps-mirror-en-pack.test.tsneeds point back INTO it. One paragraph; no code change; no gate moves.Refs: PR #8028 (#7310) · objectui#7884 · objectui#4401.
Generated by Claude Code