feat(app-shell): zero-roundtrip newTabUrl fast path for opensInNewTab actions#1675
Merged
Merged
Conversation
… actions
Actions that declare newTabUrl (spec: a path template with a {recordId}
placeholder whose target endpoint performs all auth/authz itself) now
drive the pre-opened popup straight to that URL on click, skipping the
action POST entirely. Applied to both server-action paths (list rows
via useConsoleActionRuntime, record header via RecordDetailView).
The popup paints the existing spinner page and keeps it visible until
the (possibly slow) endpoint commits its redirect; the URL is resolved
absolute because about:blank gives a bare-relative href no reliable
resolution base. Popup-blocked fallback keeps the existing toast.
First consumer: cloud sys_environment.sso_as_owner -> GET /sso-open,
which re-runs every check the POST half would have done. Removes one
full round trip of white-screen latency from every Open click.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ActionDefgainsnewTabUrl: a direct new-tab URL template ({recordId}placeholder)useConsoleActionRuntime, record header viaRecordDetailView) get a fast path: when anopensInNewTabaction also declaresnewTabUrl, the pre-opened popup is navigated straight to that URL on click — no action POSTMotivation
The cloud console's environment Open button paid a full POST round trip before the popup started navigating, even though
GET /sso-openre-runs every auth/authz check itself (defense in depth). Spec contract: framework#1787; first consumer: cloudsys_environment.sso_as_owner. Actions withoutnewTabUrlkeep the existing POST →redirectUrlflow — fully backward compatible.Test plan
pnpm --filter @object-ui/core build✓pnpm --filter @object-ui/app-shell build✓ (after rebuilding stale workspace dists: plugin-chatbot, data-objectstack, providers, react — pre-existing breakage unrelated to this change)GET /sso-openwith no prior POST 302s into the env console ✓🤖 Generated with Claude Code