fix(ui): tidy interface-page studio affordance (icon button + config-aware canvas)#1685
Merged
Merged
Conversation
Two UX papercuts on ADR-0047 interface pages, reported from the console:
1. The 'Edit in studio' page button was a long text+icon pill (and the
label fell back to English in localized UIs). Now an icon-only pencil
button (28x28) with the label kept as tooltip/aria-label.
2. Clicking it dropped the author on the page designer's empty canvas
('No regions yet / Add region') — misleading, since interface pages
are config-driven and have no regions to compose. The canvas now
detects interface pages (interfaceConfig, or a list page with no
regions) and explains they're configured in the Properties → Interface
panel, with no Add-region call to action.
Locked by PageBlockCanvas.test.tsx (3 cases: interfaceConfig, bare list,
and a region-composed page keeping the original empty state).
Browser-verified on the showcase Task Workbench: icon button + the new
canvas hint both render.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two UX papercuts on ADR-0047 interface pages, both reported from the console ("'Edit in studio' 名字太长,而且点进去也设计不了"):
Button too long / not localized — the page's
Edit in studioaffordance was a text+icon pill, and the label fell back to English in a Chinese UI. Now an icon-only pencil (28×28) with the label preserved astitle+aria-label."Can't design anything" — clicking it lands on the page designer, whose canvas showed
No regions yet / Add region. Interface pages are config-driven (regions: []; the list is generated frominterfaceConfig), so inviting the author to add regions is misleading. The canvas now detects interface pages and shows "Interface page — configured in Properties" pointing at the Properties → Interface section (added in framework#1801), with no Add-region CTA.Testing
PageBlockCanvas.test.tsx(new): 3 cases — interfaceConfig page, baretype:listpage, and a region-composed page that keeps the original empty state. All pass.@object-ui/app-shellbuild clean.🤖 Generated with Claude Code