feat(app-shell): ADR-0048 (A) — emit package-id app URLs from nav (emission layer)#1696
Merged
Conversation
…ission layer) Nav now generates `/apps/<packageId>` links instead of `/apps/<name>`: app switching (AppSwitcher/AppSidebar/CommandPalette onAppChange), sidebar base paths (AppSidebar/UnifiedSidebar), create/edit-app, and the AppHeader hidden-app switch all build via `appRouteSegment(app)` (= package id, name fallback). Route-param propagation then carries the package id through every in-app link. Browser-verified (live split backend): entering Studio via a package-id URL, all 53 in-app links emit `/apps/com.objectstack.studio/...` (0 name-based); Studio renders with full sidebar+header; `/apps/studio` (name) still resolves. Typecheck clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
xuyushun441-sys
added a commit
that referenced
this pull request
Jun 14, 2026
The console home page still built /apps/<app.name> for the app grid (HomePage) and the favorite href (AppCard), while the nav (sidebar/switcher/command-palette) emits /apps/<packageId> via appRouteSegment since #1696. So opening an app from home produced a name-form URL (/apps/studio) instead of the canonical /apps/com.objectstack.studio. Both now use appRouteSegment(app). Verified in the browser (dev console against a live backend): clicking the Studio card → /apps/com.objectstack.studio; HotCRM card → /apps/app.objectstack.hotcrm/dashboard/executive_dashboard and the app renders. Co-authored-by: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emission layer of ADR-0048 option-A routing (follows the merged resolution layer #1693 + the platform-app split framework objectstack-ai/objectstack#1813).
What
Nav now generates
/apps/<packageId>links instead of/apps/<name>:AppSwitcher/AppSidebar/CommandPaletteonAppChange→appRouteSegment(app)AppSidebar,UnifiedSidebarAppSidebarcreate-app / edit-app container segmentAppHeaderhidden-app switchRoute-param propagation then carries the package id through every in-app link.
appRouteSegmentfalls back to the app name when an app has no_packageId(runtime/DB apps), and/apps/<name>URLs still resolve (the resolution layer's name fallback), so this is backward compatible.Browser-verified (live app-showcase backend with the split)
/apps/com.objectstack.studio: 45 in-app links emit/apps/com.objectstack.studio/..., 0 emit the name; Studio renders with full sidebar + header./apps/studio(name) still resolves.Follow-up
/apps/:packageId/docs/:name+ doc filename-validation hardening (separate PR).🤖 Generated with Claude Code