fix(action): consume spec disabled (boolean|CEL) in action button (framework#1885)#1743
Merged
Conversation
…1885) The action button only read a non-spec `enabled` prop; the spec field `disabled` (boolean | CEL predicate, disabled when TRUE) had zero consumers, so a spec-authored `disabled` guard silently did nothing (metadata liveness audit, objectstack-ai/objectstack#1885, ADR-0049). `disabled` is now the primary control; the legacy non-spec `enabled` is retained as a deprecated fallback so existing metadata keeps working. Typecheck clean. Refs objectstack-ai/objectstack#1885 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This was referenced Jun 15, 2026
Merged
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This was referenced Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The action button renderer only read a non-spec
enabledprop. The spec field isdisabled(boolean | CEL predicate — disabled when TRUE), which had zero consumers — so a spec-authoreddisabledguard silently did nothing.Surfaced by the metadata property liveness audit (objectstack-ai/objectstack#1878, item #1885; ADR-0049 "enforce-or-remove").
Change
action-button.tsxnow consumesdisabledas the primary control (via the existingtoPredicateInput/useCondition, which already handle boolean + CEL{source}forms). The legacy non-specenabledis retained as a deprecated fallback so existing metadata keeps working.Verification
tsc --noEmitclean for@object-ui/components.Refs objectstack-ai/objectstack#1885
🤖 Generated with Claude Code