feat: CEL disabled on action buttons + record-page Undo wiring by os-zhuang · Pull Request #1787 · objectstack-ai/objectui

os-zhuang · 2026-06-17T01:25:13Z

What

Action UX follow-ups (the polish items from the prior round): evaluate a CEL disabled predicate on action buttons, and wire the record-page Undo affordance.

CEL `disabled` on action buttons

Action.disabled already accepted a CEL predicate in the spec, but the renderers only honoured the boolean form (the CEL was silently ignored, like visible once was). Now:

page header (components/layout/containers) evaluates disabled against the record — mirroring its existing visible eval. Verified: the CRM "Reassign Lead" header button greys out on a converted lead and is enabled otherwise.
row menu (plugin-grid/RowActionMenu) evaluates disabled per row item (boolean or CEL against the row), and skips the click when disabled.
record:quick_actions (plugin-detail) evaluates disabled per button and shows a running spinner.

So an action can now grey out conditionally (disabled) instead of only hiding (visible).

Record-page Undo wiring

action-button now forwards undoable / recordIdField on execute (they were dropped, so undoable actions lost their Undo affordance through this path).
RecordDetailView mounts useGlobalUndo and wires its success toast to offer "Undo" for undoable actions (capturing prior field values from the loaded record).

Verification notes (honest)

CEL disabled in the page header: browser-verified (greyed Reassign on a converted lead; enabled on a new lead).
CEL disabled in the row menu and the record-page Undo wiring: code-complete and mirror existing, verified patterns (the row-menu visible eval; the list-path Undo shipped earlier), but not re-driven end-to-end this session due to grid hover/menu flakiness in the harness.
Separate pre-existing gap flagged: record-header actions that require param collection don't trigger it (the header's action runtime isn't wired to the record's param-collection handler), so a param-based undoable action can't be driven from the header. Undo from the list works (shipped previously). This is out of scope here.

Only the example's "Reassign Lead" action declares a non-boolean disabled, so the new evaluation has no effect on existing actions.

🤖 Generated with Claude Code

- components/layout (page header): evaluate CEL `disabled` against the record (was boolean-only), mirroring the existing `visible` eval — actions can grey out conditionally instead of only hiding. - plugin-grid RowActionMenu: evaluate `disabled` (boolean | CEL) per row item. - components action-button: forward `undoable`/`recordIdField` on execute. - app-shell RecordDetailView: mount useGlobalUndo + wire the success toast's "Undo" for undoable actions (prior values from the loaded record). - plugin-detail record:quick_actions: CEL disabled + running spinner per button. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

vercel · 2026-06-17T01:25:19Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Jun 17, 2026 1:25am

github-actions · 2026-06-17T01:28:51Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	58.7 KB	350 KB
Entry file	`index-CNQd5Vug.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	5.95KB	2.10KB
app-shell (runtime-config.js)	4.72KB	1.69KB
app-shell (types.js)	0.01KB	0.04KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	17.16KB	3.44KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	4.79KB	1.88KB
auth (LoginForm.js)	5.11KB	1.92KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.63KB	2.15KB
auth (SocialSignInButtons.js)	8.89KB	3.61KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	24.74KB	6.00KB
auth (createAuthenticatedFetch.js)	3.33KB	1.32KB
auth (index.js)	1.75KB	0.76KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.01KB	0.79KB
auth (useIsWorkspaceAdmin.js)	1.28KB	0.70KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.42KB	0.96KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	414.03KB	87.91KB
core (index.js)	1.49KB	0.55KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	96.65KB	24.08KB
fields (index.js)	157.49KB	37.51KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.32KB	0.93KB
i18n (pickLocalized.js)	1.31KB	0.67KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	21.15KB	4.68KB
i18n (useSafeTranslation.js)	1.63KB	0.57KB
layout (index.js)	36.05KB	9.94KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	4.42KB	1.27KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	1.77KB	0.77KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	4.87KB	1.77KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.11KB	0.87KB
permissions (evaluator.js)	4.00KB	1.23KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.42KB	0.68KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	45.98KB	12.65KB
plugin-charts (index.js)	40.52KB	11.50KB
plugin-chatbot (index.js)	139.79KB	34.30KB
plugin-dashboard (index.js)	93.21KB	22.37KB
plugin-designer (index.js)	213.42KB	42.94KB
plugin-detail (index.js)	193.71KB	46.66KB
plugin-editor (index.js)	2.38KB	1.06KB
plugin-form (index.js)	90.52KB	21.62KB
plugin-gantt (index.js)	119.23KB	29.40KB
plugin-grid (index.js)	114.38KB	30.68KB
plugin-kanban (index.js)	48.82KB	13.13KB
plugin-list (index.js)	96.41KB	22.58KB
plugin-map (index.js)	16.02KB	4.98KB
plugin-markdown (index.js)	13.58KB	4.64KB
plugin-report (index.js)	34.79KB	9.13KB
plugin-timeline (index.js)	25.37KB	7.20KB
plugin-view (index.js)	84.17KB	20.29KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.55KB	0.67KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	14.98KB	4.84KB
react (index.js)	0.76KB	0.42KB
tenant (TenantContext.js)	0.31KB	0.25KB
tenant (TenantGuard.js)	1.04KB	0.43KB
tenant (TenantProvider.js)	2.76KB	0.98KB
tenant (TenantScopedQuery.js)	0.77KB	0.44KB
tenant (index.js)	0.75KB	0.38KB
tenant (resolver.js)	2.64KB	0.76KB
tenant (useTenant.js)	0.50KB	0.32KB
tenant (useTenantBranding.js)	0.62KB	0.39KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	0.77KB	0.41KB
types (disclosure.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (index.js)	1.54KB	0.68KB
types (layout.js)	0.20KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.26KB	1.96KB
types (tenant.js)	0.20KB	0.18KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	0.75KB	0.46KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

github-actions Bot added package: components plugin labels Jun 17, 2026

os-zhuang merged commit a00e16d into main Jun 17, 2026
10 checks passed

os-zhuang deleted the feat/action-record-undo-disabled branch June 17, 2026 01:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: CEL disabled on action buttons + record-page Undo wiring#1787

feat: CEL disabled on action buttons + record-page Undo wiring#1787
os-zhuang merged 1 commit into
mainfrom
feat/action-record-undo-disabled

os-zhuang commented Jun 17, 2026

Uh oh!

vercel Bot commented Jun 17, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jun 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

os-zhuang commented Jun 17, 2026

What

CEL disabled on action buttons

Record-page Undo wiring

Verification notes (honest)

Uh oh!

vercel Bot commented Jun 17, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jun 17, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

CEL `disabled` on action buttons