feat(studio): searchable icon picker for every icon field#1832
Merged
Conversation
Icon fields previously rendered as a free-text 'type a Lucide name' input unless a spec form pinned widget:'icon' — admins had to know exact icon names. - SchemaForm: auto-detect icon fields by name convention (a string prop named `icon` or `*Icon`, no enum) -> the existing 'icon' picker, mirroring the field-ref convention. Every metadata type's icon field now gets the searchable Lucide picker in the generic form without per-form wiring. - widgets: export IconPickerWidget so curated inspectors can reuse it. - ActionDefaultInspector: render the Action icon with the picker instead of a text input. Verified live: App icon (generic form) and Action icon (curated inspector) both render the picker; the searchable grid opens correctly (not clipped) inside the inspector panel. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
From an admin's perspective, picking an icon shouldn't require memorising Lucide names. The studio already ships a searchable
IconPickerWidget, but it only activated when a spec form explicitly pinnedwidget: 'icon', so most icon fields rendered as a free-text input.iconor*Icon(no enum) now resolves to theiconwidget, mirroring the existing field-reference convention. Every metadata type's icon field gets the searchable picker in the generic form, with zero per-form wiring.IconPickerWidgetso curated inspectors can reuse it.Verification
Verified live against the showcase app: the App icon (generic SchemaForm) and the Action icon (curated inspector) both now render the searchable picker; confirmed via DOM inspection that the dropdown opens with the full icon grid and is not clipped by the inspector's scroll container.
🤖 Generated with Claude Code