feat(studio): manage datasource through the metadata-admin engine (drop bespoke page)#1846
Merged
Merged
Conversation
…ot a bespoke page datasource is a metadata type, so it should be administered by the generic metadata-admin engine like every other type — not a hand-written System page. - Register `datasource` as a metadata-admin resource (registry) with a custom ListPage that ports the full manager (list / create / edit / delete / test / sync objects). It's a *side-effectful* type (secret encryption + connection pool + introspection), so writes go through the framework `datasource-admin` REST (`/api/v1/datasources/*`), but it now lives inside the engine: engine route (`…/component/metadata/resource?type=datasource`), registry slot, shell. Form uses the engine's `useMetadataClient`; sync creates objects via it. - Delete the standalone `DatasourceManagerPage` + `system/datasources` route. - Add a "Datasources" item to the console admin nav + repoint the System hub card to the engine route. - Fix MetadataRedirect/ObjectRedirect: they left a stray `system/` segment so `system/metadata/:type` 404'd — also repairs the existing "Object Manager" link. Verified live (showcase + setup apps): list, create (eng_demo), and sync (customers/orders → real object metadata) all work through the engine route. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
datasource is a metadata type, so it should be administered by the generic metadata-admin engine like every other type — not the hand-written
DatasourceManagerPage/system/datasourcesroute.datasourceas a metadata-admin resource (registerMetadataResource) with a customListPagethat ports the full manager: list / create / edit / delete / test / sync objects. It's a side-effectful type (secret encryption + connection pool + introspection), so create/edit/delete + test go through the frameworkdatasource-adminREST (/api/v1/datasources/*), but it now lives inside the engine: engine route (…/component/metadata/resource?type=datasource), registry slot, shell. Sync creates objects via the engine'suseMetadataClient.DatasourceManagerPage+system/datasourcesroute; repoint the System hub card + add an admin-nav "Datasources" item to the engine route.MetadataRedirect/ObjectRedirect: they left a straysystem/segment, sosystem/metadata/:type404'd — this also repairs the existing Object Manager link.Pairs with
framework #2091 (Setup-app "Datasources" nav entry → this engine route).
Verification (live, browser)
Against the showcase + setup apps:
eng_demo(sqlite) via the form → listedcustomers/orders→ create objects → real object metadata created (verified via/api/v1/meta/object)🤖 Generated with Claude Code