fix(grid): list column header falls back to field label, not prettified name#1991
Merged
Conversation
…ed name
A bare { field } column (no explicit label) rendered its header from the prettified
machine name even when the field had a localized label, so non-English apps showed
English column headers. ObjectGrid now resolves header = column.label -> schema field
label -> prettified name, matching the other header sites (lines ~1027/1104).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem (found dogfooding AI-built Chinese apps)
A list view whose columns are declared as bare
{ field: 'request_title' }(no explicitlabel) rendered English column headers ("Request title", "Applicant") even though the fields had Chinese labels ("申请标题", "申请人"). So an app that was otherwise fully localized (object/field/option/flow labels all Chinese) still showed English in the list header.Root cause —
ObjectGrid.tsx:863:It fell back from the column's explicit label straight to the prettified field name, never consulting the schema field's label. The other header-resolution sites in the same file (≈1027, 1104) already use
fieldDef.label— this{field}-only path was the one that didn't.Fix
Header resolution is now
column.label → field label → prettified name.Verification
dataSource.getObjectSchema; the fix mirrors the already-correct sibling sites and is live-verifiable on a Chinese AI-built app's list view.Completes the i18n story (sibling: cloud blueprint label fix) — the last English text on a Chinese app.
🤖 Generated with Claude Code