feat(list): inline editing is a configurable view property + runtime toggle - #2102
Merged
Conversation
…untime toggle Inline cell editing was effectively hardcoded per render path. Make it a first-class, per-view property with UI to flip it: - ViewSettingsPopover: a 'Record editing' toggle (mobile/compact settings). - ListView: a desktop toolbar toggle button (Pencil) for grid views, plus an onInlineEditChange callback and the popover wiring; reads schema.inlineEdit -> editable (already existed). - app-shell ObjectView (object saved views): persist the toggle to viewDef.inlineEdit via persistViewPatch, alongside sort/filter/hiddenFields. - InterfaceListPage (page lists): read inlineEdit from the page block's userActions.editInline instead of hardcoding false — inline editing becomes a page-authored property. When on, cells edit with the dedicated @object-ui/fields widgets (#2100). type-check clean; the one ListView rules-of-hooks lint warning is pre-existing (useObjectLabel try/catch). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2100 (which made inline editing use the dedicated field widgets). This makes inline editing a first-class, per-view property with UI to flip it, instead of being hardcoded per render path.
Changes
onInlineEditChangecallback + popover wiring. (schema.inlineEdit → editablealready existed.)viewDef.inlineEditviapersistViewPatch, alongside sort/filter/hiddenFields.inlineEditfrom the page block'suserActions.editInlineinstead of hardcodingfalse— inline editing becomes a page-authored property.When on, cells edit with the dedicated
@object-ui/fieldswidgets.Honest scope note
The runtime toggle UI (popover + button) is wired on the object-saved-view path. The showcase example's pages all render via InterfaceListPage (page-lists), which now reads
editInline(configurable) but doesn't surface the runtime toggle button yet. Two clean follow-ups to fully cover authored pages: (a) declareeditInlineon the page-list block schema so the metadata editor shows the toggle, or (b) passonInlineEditChangefrom InterfaceListPage for a runtime toggle there too.type-check clean; the one ListView rules-of-hooks warning is pre-existing (
useObjectLabeltry/catch).🤖 Generated with Claude Code