Skip to content

fix(form): 新建/编辑弹窗渲染对象字段分组;分组表单自动布局对齐平铺路径#2154

Merged
baozhoutao merged 1 commit into
mainfrom
claude/modal-fieldgroups-2152
Jul 2, 2026
Merged

fix(form): 新建/编辑弹窗渲染对象字段分组;分组表单自动布局对齐平铺路径#2154
baozhoutao merged 1 commit into
mainfrom
claude/modal-fieldgroups-2152

Conversation

@baozhoutao

@baozhoutao baozhoutao commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Closes #2152. 相关存量缺陷:#2153。

问题

对象声明了 fieldGroups[] + fields[].group 后:

  1. 全局"新建"弹窗(ModalForm)完全不渲染分组 —— 平铺一坨。
  2. 全页创建/编辑(ObjectForm 分组路径)绕过自动布局:不过滤系统字段、永远单列、细线标题,表单又长又丑。

修复

ModalForm(核心)

  • 无显式 sections/customFields 时,从 objectSchema.fieldGroups + field.group 推导分组(复用 deriveFieldGroupSections),并做与平铺路径完全对等的自动布局:过滤系统/自动生成字段、按字段数推断列数、宽字段(textarea/markdown 等)跨整行、多列时弹窗自动升级为 xl 宽度。显式 form view sections 永远优先,行为不变。
  • 推导出的分组渲染为单个 form + 虚拟 section-divider 标题字段(DrawerForm 同款模式),所有分组共享一个 react-hook-form 实例。不能复用现有 sections 渲染:那条路径是"每 section 一个 <form>"且共享 formId,提交按钮只关联第一个 form,第 2+ 组的值静默丢失(实测:第二组必填 status 界面已选值、POST body 缺失 → 后端 VALIDATION_FAILED)。该存量缺陷波及显式多 section 弹窗,另在 ModalForm 显式多 section 表单:每个 section 独立 <form>,提交时丢弃第 2+ 个 section 的值 #2153 跟踪。
  • 平铺字段构建时带上 Field.group;分组标题走 sectionLabel i18n。

ObjectForm 分组路径

  • 补齐自动布局对等:系统字段过滤、列数推断、applyAutoColSpan、容器查询网格类。

真实环境验证(console dev :5180 + hotcrm 后端 :4001,非 app-shell)

  • crm_campaign_member(声明 basic/response 两个 fieldGroups、无 form view):
    • 修复前:弹窗平铺无分组;(中途版本"每组一个 form"时)跨组提交丢 status,后端 400。
    • 修复后:弹窗渲染 "Basic Information" / "Response Tracking" 两组标题、两列布局、xl 宽度,无长滚动;跨组填 Campaign + Lead + Status 后提交成功,POST body 为 {"crm_campaign":…,"crm_lead":…,"status":"sent"},记录入库、列表可见、无 console 报错。
  • 回归:crm_lead 显式 "Quick Lead Creation" form view —— 渲染(卡片、双列)与提交行为均不变;单 <form>。
  • 全页 :objectName/new(ObjectForm 分组路径):分组标题 + 双列,系统字段不再出现。

测试

备注

  • 部署侧需发布新版 console 才能吃到本修复(现网跑的是已发布的 @objectstack/console)。

@vercel

vercel Bot commented Jul 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jul 2, 2026 10:15am

Request Review

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 59.1 KB 350 KB
Entry file index-BCeny2Cl.js —
Status PASS —

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 7.28KB 2.63KB
app-shell (runtime-config.js) 4.72KB 1.69KB
app-shell (types.js) 0.01KB 0.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 17.90KB 3.67KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 4.79KB 1.88KB
auth (LoginForm.js) 9.55KB 3.36KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.63KB 2.15KB
auth (SocialSignInButtons.js) 8.89KB 3.61KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 26.07KB 6.30KB
auth (createAuthenticatedFetch.js) 3.93KB 1.55KB
auth (index.js) 1.75KB 0.76KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.29KB 0.82KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.42KB 0.96KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 434.78KB 93.36KB
core (index.js) 1.65KB 0.59KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 107.48KB 26.47KB
fields (index.js) 167.32KB 40.69KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.31KB 0.67KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 21.15KB 4.68KB
i18n (useSafeTranslation.js) 2.68KB 0.98KB
layout (index.js) 36.30KB 10.04KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 4.42KB 1.27KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 1.77KB 0.77KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 5.09KB 1.84KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.46KB 1.03KB
permissions (evaluator.js) 4.00KB 1.23KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.50KB 0.70KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 45.10KB 12.33KB
plugin-charts (index.js) 46.11KB 12.99KB
plugin-chatbot (index.js) 172.75KB 41.13KB
plugin-dashboard (index.js) 108.28KB 26.86KB
plugin-designer (index.js) 213.48KB 42.95KB
plugin-detail (index.js) 200.33KB 48.19KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 98.46KB 23.90KB
plugin-gantt (index.js) 136.67KB 33.88KB
plugin-grid (index.js) 156.94KB 41.43KB
plugin-kanban (index.js) 48.15KB 12.94KB
plugin-list (index.js) 97.93KB 23.09KB
plugin-map (index.js) 16.02KB 4.98KB
plugin-markdown (index.js) 13.65KB 4.67KB
plugin-report (index.js) 37.83KB 9.97KB
plugin-timeline (index.js) 25.37KB 7.20KB
plugin-tree (index.js) 8.21KB 2.76KB
plugin-view (index.js) 84.50KB 20.37KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.55KB 0.67KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 3.19KB 1.38KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 18.23KB 5.97KB
react (index.js) 0.76KB 0.42KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 2.16KB 0.94KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
tenant (TenantContext.js) 0.31KB 0.25KB
tenant (TenantGuard.js) 1.04KB 0.43KB
tenant (TenantProvider.js) 2.76KB 0.98KB
tenant (TenantScopedQuery.js) 0.77KB 0.44KB
tenant (index.js) 0.75KB 0.38KB
tenant (resolver.js) 2.64KB 0.76KB
tenant (useTenant.js) 0.50KB 0.32KB
tenant (useTenantBranding.js) 0.62KB 0.39KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.77KB 0.41KB
types (disclosure.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 1.54KB 0.68KB
types (layout.js) 0.20KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.26KB 1.96KB
types (tenant.js) 0.20KB 0.18KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 0.75KB 0.46KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@baozhoutao baozhoutao merged commit d006128 into main Jul 2, 2026
10 checks passed
@baozhoutao baozhoutao deleted the claude/modal-fieldgroups-2152 branch July 2, 2026 15:06
@baozhoutao
fix(form): render object fieldGroups in create/edit modal; auto-layou…
fd926ba 
…t parity for grouped ObjectForm (#2152)

ModalForm ignored the object's fieldGroups designer metadata entirely —
the global create modal rendered grouped objects as one flat field pile.
ObjectForm's grouped path bypassed applyAutoLayout: no system-field
filtering, always single column, hairline group titles on an endlessly
scrolling form.

- ModalForm: when no explicit sections/customFields are passed, derive
  sections from objectSchema.fieldGroups + field.group (same
  deriveFieldGroupSections as ObjectForm), with flat-path auto-layout
  parity: system/auto-generated fields filtered, columns inferred from
  field count, wide fields spanning the row, modal size auto-upgraded
  for multi-column. Explicit curated sections always win.
- The derived groups render as ONE form with virtual section-divider
  fields (DrawerForm's pattern) — NOT one SchemaRenderer per section.
  Per-section renderers create N <form> elements sharing the footer
  button's form id, so only the first section's values ever submit
  (verified live: group 2's required status showed a value in the UI
  but was absent from the POST body → VALIDATION_FAILED). That latent
  flaw still affects the explicit-sections path; tracked in #2153.
- ModalForm's flat field builder now carries Field.group so derivation
  sees group membership; section headers go through sectionLabel i18n.
- ObjectForm grouped path: filter system/auto-generated fields, infer
  columns, applyAutoColSpan, container-query grid — matching the flat
  path.

Verified against a real console (:5180) + real hotcrm backend (:4001):
crm_campaign_member (fieldGroups, no form view) modal now shows both
group headers in a 2-column xl dialog, and a cross-group create submits
all values (record persisted, POST body contains every group's fields).
crm_lead's explicit "Quick Lead Creation" view renders and submits
unchanged. plugin-form: 155/155 tests, type-check green.

Closes #2152
@os-zhuang os-zhuang mentioned this pull request Jul 3, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

plugin tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

新建/编辑弹窗不渲染对象字段分组(fieldGroups);全页分组表单为单列且样式简陋

1 participant

@baozhoutao