feat: consume ADR-0085 semantic roles from spec 11.7.0#2168
Merged
Conversation
… fieldGroups, stageField:false, highlightFields) - plugin-form/plugin-detail grouping now adapts @objectstack/spec's deriveFieldGroupLayout (ADR-0085 §5) — one derivation for forms, modals and detail pages; canonical collapse enum honoured with deprecated collapsible/collapsed/defaultExpanded read for pre-11.7 metadata. - detectStatusField reads the top-level stageField role; false now suppresses the record:path stepper (was wired to the removed detail.stageField, so spec-authored false fell through to the heuristic — dogfood-confirmed gap). - Default grid columns / cards / highlight strip / child previews / interface pages read highlightFields with compactLayout fallback. - Dead reads removed: objectDef.views.* and the ADR-0085-removed detail.* hint block. detail.renderViaSchema survives only as the legacy-renderer kill-switch (removed with that path in a follow-up). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consumer-side switch for framework ADR-0085 (spec 11.7.0). Closes the four dogfood-confirmed gaps:
What
plugin-form'sderiveFieldGroupSectionsandplugin-detail'sderiveFieldGroupDetailSectionsare now thin adapters over spec'sderiveFieldGroupLayout. Forms, the create/edit modal (新建/编辑弹窗不渲染对象字段分组(fieldGroups);全页分组表单为单列且样式简陋 #2152/fix(form): 新建/编辑弹窗渲染对象字段分组;分组表单自动布局对齐平铺路径 #2154 pipeline) and detail pages render the SAME grouping from one implementation; the two near-identical local copies are gone (net -90 lines).collapseenum honoured everywhere —'none' | 'expanded' | 'collapsed'; deprecatedcollapsible/collapsed/defaultExpandedspellings still read for pre-11.7 metadata (handled inside the shared derivation).stageField: falseactually suppresses the stepper — thefalsehandling was wired to the removeddetail.stageFieldkey, so spec-authoredfalsefell through to the name heuristic (browser-confirmed bug).highlightFieldsrename consumed — default grid columns, card compact views, detail highlight strip, child-record preview and interface-page default columns readhighlightFieldswithcompactLayoutfallback for pre-11.7 metadata.objectDef.views.*and the ADR-0085-removeddetail.*hint block.detail.renderViaSchemasurvives only as the legacy-renderer kill-switch (dies with that path in a follow-up PR).Verification
stageField: false→ stepper GONE (was rendering pre-fix);stageField: 'status'→ stepper renders.collapse: 'collapsed'group renders as a collapsed card on the detail page, expandable.highlightFields(new spelling) andcompactLayout(legacy spelling) both.🤖 Generated with Claude Code