Skip to content

feat: consume ADR-0085 semantic roles from spec 11.7.0#2168

Merged
os-zhuang merged 1 commit into
mainfrom
feat/adr-0085-consumer-switch
Jul 3, 2026
Merged

feat: consume ADR-0085 semantic roles from spec 11.7.0#2168
os-zhuang merged 1 commit into
mainfrom
feat/adr-0085-consumer-switch

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

Consumer-side switch for framework ADR-0085 (spec 11.7.0). Closes the four dogfood-confirmed gaps:

What

  1. Single-source fieldGroups derivation (§5)plugin-form's deriveFieldGroupSections and plugin-detail's deriveFieldGroupDetailSections are now thin adapters over spec's deriveFieldGroupLayout. Forms, the create/edit modal (新建/编辑弹窗不渲染对象字段分组(fieldGroups);全页分组表单为单列且样式简陋 #2152/fix(form): 新建/编辑弹窗渲染对象字段分组;分组表单自动布局对齐平铺路径 #2154 pipeline) and detail pages render the SAME grouping from one implementation; the two near-identical local copies are gone (net -90 lines).
  2. Canonical collapse enum honoured everywhere'none' | 'expanded' | 'collapsed'; deprecated collapsible/collapsed/defaultExpanded spellings still read for pre-11.7 metadata (handled inside the shared derivation).
  3. stageField: false actually suppresses the stepper — the false handling was wired to the removed detail.stageField key, so spec-authored false fell through to the name heuristic (browser-confirmed bug).
  4. highlightFields rename consumed — default grid columns, card compact views, detail highlight strip, child-record preview and interface-page default columns read highlightFields with compactLayout fallback for pre-11.7 metadata.
  5. Dead reads removed — never-authorable objectDef.views.* and the ADR-0085-removed detail.* hint block. detail.renderViaSchema survives only as the legacy-renderer kill-switch (dies with that path in a follow-up PR).

Verification

  • Unit: plugin-form 15 / plugin-detail 146 / app-shell 958 / plugin-grid 162 — all green.
  • Browser (app-todo + HMR console against a live worktree server):
    • stageField: false → stepper GONE (was rendering pre-fix); stageField: 'status' → stepper renders.
    • collapse: 'collapsed' group renders as a collapsed card on the detail page, expandable.
    • Create modal shows the Planning group header (was flat — the main console entry surface).
    • Default list columns / highlight strip / card views driven by highlightFields (new spelling) and compactLayout (legacy spelling) both.

🤖 Generated with Claude Code

… fieldGroups, stageField:false, highlightFields)

- plugin-form/plugin-detail grouping now adapts @objectstack/spec's
  deriveFieldGroupLayout (ADR-0085 §5) — one derivation for forms,
  modals and detail pages; canonical collapse enum honoured with
  deprecated collapsible/collapsed/defaultExpanded read for pre-11.7
  metadata.
- detectStatusField reads the top-level stageField role; false now
  suppresses the record:path stepper (was wired to the removed
  detail.stageField, so spec-authored false fell through to the
  heuristic — dogfood-confirmed gap).
- Default grid columns / cards / highlight strip / child previews /
  interface pages read highlightFields with compactLayout fallback.
- Dead reads removed: objectDef.views.* and the ADR-0085-removed
  detail.* hint block. detail.renderViaSchema survives only as the
  legacy-renderer kill-switch (removed with that path in a follow-up).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jul 3, 2026 1:22am

Request Review

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 59.1 KB 350 KB
Entry file index-BD32AHKG.js
Status PASS

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 7.28KB 2.63KB
app-shell (runtime-config.js) 4.72KB 1.69KB
app-shell (types.js) 0.01KB 0.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 17.90KB 3.67KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 4.79KB 1.88KB
auth (LoginForm.js) 9.55KB 3.36KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.63KB 2.15KB
auth (SocialSignInButtons.js) 8.89KB 3.61KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 26.07KB 6.30KB
auth (createAuthenticatedFetch.js) 3.93KB 1.55KB
auth (index.js) 1.75KB 0.76KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.29KB 0.82KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.42KB 0.96KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 435.50KB 93.51KB
core (index.js) 1.65KB 0.59KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 109.24KB 26.96KB
fields (index.js) 184.34KB 44.89KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.31KB 0.67KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 21.15KB 4.68KB
i18n (useSafeTranslation.js) 2.68KB 0.98KB
layout (index.js) 36.30KB 10.04KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 4.42KB 1.27KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 1.77KB 0.77KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 5.09KB 1.84KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.46KB 1.03KB
permissions (evaluator.js) 4.00KB 1.23KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.50KB 0.70KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 45.10KB 12.33KB
plugin-charts (index.js) 46.11KB 12.99KB
plugin-chatbot (index.js) 172.75KB 41.13KB
plugin-dashboard (index.js) 108.28KB 26.86KB
plugin-designer (index.js) 213.48KB 42.95KB
plugin-detail (index.js) 201.48KB 48.49KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 98.04KB 23.85KB
plugin-gantt (index.js) 136.67KB 33.88KB
plugin-grid (index.js) 158.25KB 41.85KB
plugin-kanban (index.js) 48.15KB 12.94KB
plugin-list (index.js) 97.89KB 23.09KB
plugin-map (index.js) 16.02KB 4.98KB
plugin-markdown (index.js) 13.65KB 4.67KB
plugin-report (index.js) 37.83KB 9.97KB
plugin-timeline (index.js) 25.37KB 7.20KB
plugin-tree (index.js) 8.21KB 2.76KB
plugin-view (index.js) 84.50KB 20.37KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.55KB 0.67KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 3.19KB 1.38KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 18.23KB 5.97KB
react (index.js) 0.76KB 0.42KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 2.16KB 0.94KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
tenant (TenantContext.js) 0.31KB 0.25KB
tenant (TenantGuard.js) 1.04KB 0.43KB
tenant (TenantProvider.js) 2.76KB 0.98KB
tenant (TenantScopedQuery.js) 0.77KB 0.44KB
tenant (index.js) 0.75KB 0.38KB
tenant (resolver.js) 2.64KB 0.76KB
tenant (useTenant.js) 0.50KB 0.32KB
tenant (useTenantBranding.js) 0.62KB 0.39KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.77KB 0.41KB
types (disclosure.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 1.54KB 0.68KB
types (layout.js) 0.20KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.26KB 1.96KB
types (tenant.js) 0.20KB 0.18KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 0.75KB 0.46KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang os-zhuang merged commit 144ab55 into main Jul 3, 2026
10 checks passed
@os-zhuang os-zhuang deleted the feat/adr-0085-consumer-switch branch July 3, 2026 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant