fix(app-shell): don't show recovery-password reminder on a user's first landing#2183
Merged
Conversation
… first landing
The RecoveryPasswordReminder banner ("Set a recovery password so you can still
sign in if SSO is ever unavailable") fired on the env home whenever an SSO user
had no local password — including a brand-new user's very first screen, before
they've built anything. Premature: it loads the first-run magic moment with a
resilience nudge the user has no reason to care about yet. (The component's own
comment already intends "not before the first session"; the code didn't honor it.)
Gate on a first-visit marker: record the first home landing, show the reminder
only from the next visit onward. Still dismissible; still SSO-fallback resilience
for the default (password-allowed) envs.
Follow-up: the reminder also shows on SSO-enforced envs where password login is
disabled (recovery password unusable there) — that gate is separate.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RecoveryPasswordReminder fired on the env home on a brand-new SSO user's very first screen (before they've built anything) — premature friction on the first-run magic moment. The component already intends 'not before the first session' but the code didn't honor it. Gate on a first-visit localStorage marker: record the first home landing, show the reminder only from the next visit on. Still dismissible; preserves SSO-fallback resilience for default (password-allowed) envs. Follow-up: also gate off SSO-enforced envs where the password can't be used.