chore(metadata-admin): stop surfacing metadata fields the spec dropped (framework#2377)#2658
Merged
Merged
Conversation
…d (framework#2377) Two dead, unenforced author-facing props that framework PR #3176 removes from @objectstack/spec were still *displayed* (never enforced) in the Studio metadata-admin — the same false affordance on the UI side. Both were read defensively off raw docs, so this is display-only with no runtime impact: - dataset measure `certified`: useDatasetCatalog populated a DatasetMeasureInfo.certified flag (+ a passthrough field in DatasetDefaultInspector's local Measure type) that nothing rendered. Dropped. - agent planning `strategy`/`allowReplan`: AgentPreview's Planning rail listed both; narrowed KeyVals keys to ['maxIterations'] (the only live knob). Test fixtures setting `certified` updated. No public component API change. metadata-admin suite green (799 tests). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011XchBKhKdjbhQZymt9Gn9B
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
os-zhuang
marked this pull request as ready for review
July 18, 2026 07:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion cleanup to framework PR objectstack-ai/framework#3176 (ADR-0049 enforce-or-remove). That PR removes a batch of dead, unenforced author-facing metadata properties from
@objectstack/spec. Two of them were still displayed (never enforced, just shown) in the Studio metadata-admin — the same false affordance on the UI side. Both were read defensively off raw documents (Record<string, unknown>,=== true, dynamic keys), so removing the spec fields does not break objectui — this PR just stops the UI from surfacing fields the spec no longer supports.Changes (all in
@object-ui/app-shell, display-only)datasetmeasurecertified—useDatasetCatalogpopulated aDatasetMeasureInfo.certifiedflag, andDatasetDefaultInspectorcarriedcertifiedin its localMeasuretype, but nothing ever rendered it (agrepacross the repo finds it only in these type/population sites and test fixtures — no badge/consumer). Dropped the type field + its population.agent.planning.strategy/allowReplan—AgentPreview's Planning rail listed both via<KeyVals keys={['strategy','maxIterations','allowReplan']}>. Narrowed to['maxIterations']— the only planning field the runtime actually reads (kept live in the spec).Test fixtures that set
certifiedwere updated (DatasetDefaultInspector.test.tsx,ReportDefaultInspector.test.tsx). No public component API change.Verification
vitest run metadata-admin), including the two edited inspector tests.tscerrors in this package are pre-existing build-order noise (unbuilt@object-ui/*sibling.d.ts, plus untouched implicit-anys inStudioDesignSurface.tsx) — none are in the files this PR touches.Coordination
Independent of the framework merge — safe to land before or after #3176 (objectui reads these fields defensively either way). Best merged around the same window so the spec and Studio stay consistent.
🤖 Generated with Claude Code
Generated by Claude Code