feat(form): consume spec-aligned FormView buttons/defaults in ObjectForm by os-zhuang · Pull Request #2790 · objectstack-ai/objectui

os-zhuang · 2026-07-22T21:27:19Z

What

Teaches the form renderer to consume the structured, spec-aligned
FormViewSchema.buttons / FormViewSchema.defaults surface from @objectstack/spec.

The authored spec carries buttons.{submit,cancel,reset}.{show,label} and
defaults (create-mode initial values), but ObjectForm only ever read the
flat renderer-invented showSubmit/submitText/showCancel/cancelText/
showReset/initialValues. That left the two spec keys parsed-but-inert
(ADR-0078) and stuck at experimental in the spec liveness ledger.

How

@object-ui/types — add optional buttons / defaults to
ObjectFormSchema; mark the flat initialValues deprecated in favor of defaults.
ObjectForm — a new foldFormButtons() runs inside the existing schema
normalization pass and folds the structured shape down onto the flat props the
component (and every variant it dispatches into) already read. Returns the
input untouched when neither key is present (no hot-path allocation). An
explicitly-set flat key still wins, so metadata authored against the deprecated
flat keys is unchanged.
ObjectView + RecordFormPage — forward buttons/defaults from the
spec form view so both entry paths honor them.

This is the objectui-side consumer that lets the framework flip the two ledger
entries experimental → live (paired PR: objectstack-ai/objectstack — closes
the view item of objectstack-ai/objectstack#1894).

Testing

New formButtonsDefaults.test.tsx (3 cases): buttons.submit.label becomes
the submit text; defaults seed create-mode initial values; an explicit flat
key wins over the structured block.
type-check green across @object-ui/types, plugin-form, plugin-view,
app-shell (turbo, deps built).
Full plugin-form + plugin-view DOM suite green (118 tests, no regression).

Refs objectstack-ai/objectstack#1894, objectstack-ai/objectstack#2998, #2545.

🤖 Generated with Claude Code

Generated by Claude Code

The authored @objectstack/spec FormViewSchema carries structured `buttons.{submit,cancel,reset}.{show,label}` and `defaults`, but the form renderer only ever read the flat renderer-invented `showSubmit`/`submitText`/ `showCancel`/`cancelText`/`showReset`/`initialValues`. That left the two spec keys parsed-but-inert (ADR-0078) and stuck at `experimental` in the spec liveness ledger. ObjectForm now folds the structured shape down onto those flat props inside its existing normalization pass, so every entry path (ObjectView drawer/modal/page, RecordFormPage) honors it. An explicitly-set flat key still wins, so metadata authored against the deprecated flat keys is unchanged. ObjectView and RecordFormPage forward `buttons`/`defaults` from the spec form view. Refs objectstack-ai/objectstack#1894, objectstack-ai/objectstack#2998. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CMaDBhnZEUu1fcw8Rvo6Yq

vercel · 2026-07-22T21:27:24Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Jul 22, 2026 9:29pm

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CMaDBhnZEUu1fcw8Rvo6Yq

os-zhuang · 2026-07-22T21:30:41Z

CI red is a runner-allocation outage, not this diff. Every job on both my SHAs (bfa0d4c, f889ddf) completed in ~2s with runner_id: 0 / empty runner_name and no downloadable logs — GitHub Actions never assigned a runner. It hits every job uniformly, including the trivial label check, so it's platform-side, not the change.

The diff is verified green locally: type-check passes across @object-ui/types, plugin-form, plugin-view, app-shell (turbo, deps built), and the full plugin-form + plugin-view DOM suite passes (118 tests) plus the new formButtonsDefaults fold test (3 cases).

I'll re-run the failed jobs once runners recover and report back. No action needed on the code meanwhile.

Generated by Claude Code

github-actions · 2026-07-24T11:25:59Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	28.0 KB	350 KB
Entry file	`index-CxR-VVDz.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	8.19KB	2.96KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	21.70KB	4.21KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.12KB	3.41KB
auth (LoginForm.js)	17.86KB	5.29KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.43KB	2.09KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	33.74KB	8.53KB
auth (createAuthenticatedFetch.js)	4.37KB	1.69KB
auth (index.js)	1.83KB	0.79KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.86KB	0.85KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	450.13KB	97.87KB
core (index.js)	1.86KB	0.63KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	125.29KB	31.48KB
fields (index.js)	211.66KB	51.78KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.70KB	0.83KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	25.17KB	5.80KB
i18n (useSafeTranslation.js)	2.87KB	1.28KB
layout (index.js)	38.45KB	10.67KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	4.42KB	1.27KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	1.77KB	0.77KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	5.90KB	2.15KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.46KB	1.03KB
permissions (evaluator.js)	4.00KB	1.23KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.50KB	0.70KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	45.37KB	12.48KB
plugin-charts (index.js)	46.90KB	13.26KB
plugin-chatbot (index.js)	179.53KB	42.79KB
plugin-dashboard (index.js)	108.70KB	27.99KB
plugin-designer (index.js)	210.92KB	42.69KB
plugin-detail (index.js)	214.78KB	52.42KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	103.47KB	25.10KB
plugin-gantt (index.js)	162.33KB	39.53KB
plugin-grid (index.js)	174.13KB	45.90KB
plugin-kanban (index.js)	47.45KB	12.99KB
plugin-list (index.js)	98.59KB	23.27KB
plugin-map (index.js)	16.80KB	5.24KB
plugin-markdown (index.js)	13.65KB	4.67KB
plugin-report (index.js)	37.81KB	9.98KB
plugin-timeline (index.js)	25.37KB	7.20KB
plugin-tree (index.js)	8.36KB	2.81KB
plugin-view (index.js)	85.70KB	20.87KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.55KB	0.67KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	3.19KB	1.38KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	18.70KB	6.09KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.00KB	0.55KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	2.16KB	0.94KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	0.77KB	0.41KB
types (disclosure.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (index.js)	2.02KB	0.95KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.26KB	1.96KB
types (system-fields.js)	2.39KB	1.17KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	0.75KB	0.46KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

chore: add changeset for FormView buttons/defaults fold

f889ddf

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CMaDBhnZEUu1fcw8Rvo6Yq

os-zhuang mentioned this pull request Jul 22, 2026

[P2] Inverse drift — renderers read undeclared props objectstack-ai/objectstack#1894

Closed

3 tasks

github-actions Bot added package: types plugin tests labels Jul 24, 2026

os-zhuang marked this pull request as ready for review July 24, 2026 12:12

os-zhuang merged commit 6dee2cb into main Jul 24, 2026
21 of 83 checks passed

os-zhuang deleted the claude/inverse-drift-form-buttons-defaults branch July 24, 2026 12:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(form): consume spec-aligned FormView buttons/defaults in ObjectForm#2790

feat(form): consume spec-aligned FormView buttons/defaults in ObjectForm#2790
os-zhuang merged 2 commits into
mainfrom
claude/inverse-drift-form-buttons-defaults

os-zhuang commented Jul 22, 2026

Uh oh!

vercel Bot commented Jul 22, 2026 •

edited

Loading

Uh oh!

os-zhuang commented Jul 22, 2026

Uh oh!

github-actions Bot commented Jul 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

os-zhuang commented Jul 22, 2026

What

How

Testing

Uh oh!

vercel Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

os-zhuang commented Jul 22, 2026

Uh oh!

github-actions Bot commented Jul 24, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel Bot commented Jul 22, 2026 •

edited

Loading