Skip to content

feat: render the server's effective API operation set (#3391 PR-4) - #2823

Merged
os-zhuang merged 1 commit into
mainfrom
claude/effective-api-operations-ui-3391
Jul 27, 2026
Merged

feat: render the server's effective API operation set (#3391 PR-4)#2823
os-zhuang merged 1 commit into
mainfrom
claude/effective-api-operations-ui-3391

Conversation

@os-zhuang

@os-zhuang os-zhuang commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

背景

#3391 的前端配套(方案里的 PR-4,objectui 侧)。框架侧 P1(spec/runtime/rest/hono)已合并(objectstack#3498),/me/permissions 现下发 per-object apiOperations(服务端解析的有效操作集)。本 PR 让前端消费下发的 effective 结果——不读原始 apiMethods、不自行派生——使按钮与服务端实际放行一致,并让导入 405 出独立文案而非静默回退。

改动

  • core resolveCrudAffordances(obj, effectiveApiOperations?) —— 新增可选第二参,逐位与 API 操作交集(create/import→create/import、edit→update、delete→delete、exportCsv→export)。省略即不变(向后兼容);空数组 = 全禁。
  • permissions —— /me/permissions 响应补 per-object apiOperations;PermissionContextValue.getObjectApiOperations(object) 暴露之(缺失→undefined→回退现行为);check() 补 import→allowCreate、export→allowRead;角色 provider 与无 provider 路径返回 undefined。
  • app-shell ObjectView —— 工具栏 affordances 与对象 effective 操作交集(Import);平台管理员 identity-import 旁路不受影响。
  • plugin-list ListView / plugin-grid ObjectGrid —— Export 按钮与 handler 门控在 effective export;plugin-grid 补 @object-ui/permissions workspace 依赖(现缺)。
  • plugin-grid ImportWizard —— 新增 isImportNotAllowed(405 / OBJECT_API_METHOD_NOT_ALLOWED)谓词,在四个 catch 点(async / handleImport / sync / dry-run)先于 unsupported 判定;命中即终止并出独立文案 grid.import.notAllowed(10 locale + fallback 字典),决不回退同步/legacy(它们同样 405),与 404「路由不存在→回退」语义相反。

向后兼容

effective 缺失(unrestricted 对象 / 旧后端 / 无 permission provider)处处回退现行为;新旧前后端任意组合可用。

测试

  • core:resolveCrudAffordances 第二参矩阵(缺失零变化 / 逐位 AND / 空数组全禁 / 不越权重开)。
  • permissions:getObjectApiOperations 读取与缺失、check('import')→allowCreate、check('export')→allowRead。
  • plugin-grid:isImportNotAllowed 矩阵(code/status/statusCode/httpStatus/裸 405 命中;404、UNSUPPORTED_OPERATION 不命中;405 优先于 unsupported 判定)。
  • 涉及包全量测试通过:core 89 / permissions 89 / plugin-list 163 / plugin-grid 237 / app-shell 89;type-check 全绿;lint 0 errors。

关联

  • objectstack#3391(跟踪)/ objectstack#3498(框架侧 P1,已合并)。

🤖 Generated with Claude Code

https://claude.ai/code/session_012L8EfEa157Pe6C73qRnaJH

Generated by Claude Code

@claude
feat: render the server's effective API operation set (#3391 PR-4)
4f52a40 
The frontend now consumes the per-object effective API operation set the server
resolves (/me/permissions apiOperations, framework #3391) — never the raw
apiMethods — so CRUD/Import/Export buttons match what the server will admit, and
a 405 import refusal shows a dedicated message instead of a silent fallback.

- core: resolveCrudAffordances(obj, effectiveApiOperations?) — optional 2nd arg
  intersects each affordance bit with its API operation (create/import→create/
  import, edit→update, delete→delete, exportCsv→export). Omitting it leaves
  affordances unchanged (backward-compatible).
- permissions: /me/permissions response carries per-object apiOperations;
  PermissionContextValue.getObjectApiOperations(object) exposes it (undefined
  when absent → current behavior); check() maps import→allowCreate,
  export→allowRead. Role-based + no-provider paths return undefined.
- app-shell ObjectView: toolbar affordances intersect with effective operations
  (Import); the identity-import admin bypass is unaffected.
- plugin-list ListView / plugin-grid ObjectGrid: Export button + handler gate on
  effective `export`; plugin-grid gains the @object-ui/permissions dependency.
- plugin-grid ImportWizard: new isImportNotAllowed predicate (405 /
  OBJECT_API_METHOD_NOT_ALLOWED) at all catch sites STOPS with a dedicated
  grid.import.notAllowed message (10 locales + fallback), never falling back to
  the sync/legacy path — distinct from the 404 route-absent fallback.

Tests: resolveCrudAffordances 2nd-arg matrix, getObjectApiOperations +
check(import/export) mapping, isImportNotAllowed matrix (405 vs 404/unsupported).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012L8EfEa157Pe6C73qRnaJH
@vercel

vercel Bot commented Jul 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jul 27, 2026 2:48am

Request Review

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 28.0 KB 350 KB
Entry file index-D8o0Ifou.js —
Status PASS —

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 8.19KB 2.96KB
app-shell (runtime-config.js) 7.42KB 2.32KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 7.57KB 2.97KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 21.70KB 4.21KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.12KB 3.41KB
auth (LoginForm.js) 17.86KB 5.29KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.43KB 2.09KB
auth (SocialSignInButtons.js) 9.60KB 3.89KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 33.74KB 8.53KB
auth (createAuthenticatedFetch.js) 4.37KB 1.69KB
auth (index.js) 1.83KB 0.79KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.86KB 0.85KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 450.70KB 98.15KB
core (index.js) 1.86KB 0.63KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 127.29KB 31.96KB
fields (index.js) 212.79KB 52.07KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.70KB 0.83KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 25.17KB 5.80KB
i18n (useSafeTranslation.js) 2.87KB 1.28KB
layout (index.js) 38.45KB 10.67KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 4.42KB 1.27KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 1.77KB 0.77KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 6.84KB 2.42KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.67KB 1.12KB
permissions (evaluator.js) 4.00KB 1.23KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.55KB 0.71KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 45.37KB 12.48KB
plugin-charts (index.js) 46.90KB 13.26KB
plugin-chatbot (index.js) 179.53KB 42.79KB
plugin-dashboard (index.js) 108.71KB 28.00KB
plugin-designer (index.js) 210.92KB 42.69KB
plugin-detail (index.js) 214.78KB 52.42KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 103.47KB 25.10KB
plugin-gantt (index.js) 162.33KB 39.53KB
plugin-grid (index.js) 176.45KB 46.34KB
plugin-kanban (index.js) 47.82KB 13.18KB
plugin-list (index.js) 98.71KB 23.32KB
plugin-map (index.js) 16.80KB 5.24KB
plugin-markdown (index.js) 13.65KB 4.67KB
plugin-report (index.js) 37.07KB 9.81KB
plugin-timeline (index.js) 25.37KB 7.20KB
plugin-tree (index.js) 8.36KB 2.81KB
plugin-view (index.js) 85.70KB 20.87KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.55KB 0.67KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 3.19KB 1.38KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 18.70KB 6.09KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 1.00KB 0.55KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 2.16KB 0.94KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.77KB 0.41KB
types (disclosure.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 1.97KB 0.93KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.04KB 1.93KB
types (system-fields.js) 2.39KB 1.17KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 0.75KB 0.46KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang marked this pull request as ready for review July 27, 2026 03:21
@os-zhuang
os-zhuang merged commit 2735de6 into main Jul 27, 2026
14 checks passed
@os-zhuang
os-zhuang deleted the claude/effective-api-operations-ui-3391 branch July 27, 2026 03:21
This was referenced Jul 27, 2026
Closed
Merged
os-zhuang added a commit that referenced this pull request Jul 28, 2026
@os-zhuang @claude
feat(grid): gate list row Edit/Delete and bulk delete on the effectiv…
ba45145 
…e operation set (objectstack#3720) (#2889)

The fourth surface objectstack#3391 left open. The toolbar (#2823), detail/form
(#2832 + #2876) and related lists (#2832) all route through `resolveCrudAffordances`;
the main list's row CRUD has its own resolver and none of those rounds reached it.
Its gate was `operations ?? { update: !!onEdit, delete: !!onDelete }`, and ObjectView
wires onEdit/onDelete unconditionally while view JSON rarely declares `operations` —
so it was effectively always-on. A caller whose effective set carried neither `update`
nor `delete` still got the row kebab's Edit/Delete and the bulk delete.

- plugin-grid `resolveRowCrudAffordances` takes `managedBy` + `effectiveApiOperations`
  and resolves the object verdict through the shared `resolveCrudAffordances` policy,
  so the row gate is the same decision every other face makes. It also returns
  `objectCanDelete` — bulk delete rides `onBulkDelete`, a different callback from the
  row `onDelete`, so it must not be judged by whether the row handler happens to be wired.
- plugin-grid `ObjectGrid` threads its existing `effectiveApiOps` (until now fed only to
  Export) into the row gate, and applies the delete verdict to bulk delete: the implicit
  `['delete']`, a declared `bulkActions: ['delete']`, and any `bulkActionDefs` entry with
  `operation: 'delete'`. Custom ids and non-delete operations pass through untouched.
- plugin-list `ListView`'s own bulk bar (the non-grid views) drops its built-in `delete`
  under the same verdict.

Also closes the ADR-0103 gap on this chain: the bucket lock was documented as applied
upstream via the view's `operations.*`, but the all-open default meant it never was —
an engine-owned system / append-only / better-auth object leaked a generic row
Edit/Delete the engine rejects. A `userActions` opt-in still re-opens it.

Intersection, never union. A missing effective set preserves current behavior.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies package: core plugin tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@os-zhuang @claude