Skip to content

fix(page,field): consume the spec's type/label/maxLength keys (framework#1878 §3 recheck) - #2867

Merged
os-zhuang merged 1 commit into
mainfrom
fix/naming-drift-page-and-maxlength
Jul 27, 2026
Merged

fix(page,field): consume the spec's type/label/maxLength keys (framework#1878 §3 recheck)#2867
os-zhuang merged 1 commit into
mainfrom
fix/naming-drift-page-and-maxlength

Conversation

@os-zhuang

@os-zhuang os-zhuang commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Companion to objectstack-ai/objectstack docs/naming-drift-recheck. Three FORWARD-DRIFTs found by rechecking the 2026-06 audit's §3 list — cases where objectui reads a different key than the spec declares, so the author does everything right and nothing happens.

1 + 2. The page pair (coupled — must land together)

PageSchema declares the page KIND as type (record|home|app|utility|list) and requires label. But:

  • PageRenderer reads schema.pageType with a 'record' fallback (page.tsx:391) — and nothing mapped type → pageType. The boundary passed type only (PageView.tsx:123).
  • the region renderer reads only schema.title, never label (page.tsx:503-507).

Coupled because the header is gated on pageType !== 'record' — pinned false by drift #1, so wiring label alone would still render no title.

Observable today in the showcase: capability_map (type:'home'), active_projects (type:'list') and command_center_jsx (type:'home') all rendered as record pages — record max-width, data-page-type="record", no title.

Why it hid for a year: the spec's type defaults to 'record' and the renderer's fallback is 'record', so the most common page kind looked correct by coincidence.

Fix: PageView passes pageType alongside type (which must stay — ComponentRegistry dispatches on it), and PageRenderer dual-reads title ?? label, mirroring the fallback DashboardRenderer already uses.

3. field maxLength / minLength

Validation already dual-reads these (fields/src/index.tsx:2013,2022, citing the same #1878 closeout), but two readers were missed: ObjectForm's HTML-attribute pass (:607-608) and TextAreaField (:39) read max_length only — so a spec-authored maxLength produced no browser cap and no character counter. Both now dual-read.

Verification

  • Browser-verified against the showcase: capability_map now reports data-page-type="home", max-w-screen-2xl and renders its <h1>Capability Map (screenshot in the framework PR thread). Record pages re-checked unchanged — still data-page-type="record", no duplicate title.
  • 625 tests green across components / app-shell / plugin-form / fields; all four packages build.

🤖 Generated with Claude Code

@os-zhuang @claude
fix(page,field): consume the spec's type/label/maxLength keys (framew…
60e9369 
…ork#1878 §3 recheck)

Three forward-drifts where objectui read a different key than the spec
declares, so authoring the documented key silently no-oped:

- page `type` -> `pageType`: PageSchema declares the page KIND as `type`;
  PageRenderer reads `schema.pageType` with a 'record' fallback and NOTHING
  mapped between them, so every non-record page (home/app/list/utility)
  rendered with the record max-width, a wrong data-page-type and a
  suppressed header. PageView now passes pageType alongside the SchemaNode
  discriminator `type` (which must stay -- ComponentRegistry dispatches on it).
- page `label` -> `title`: PageSchema.label is required but the region
  renderer read only `title`. Dual-reads now, mirroring DashboardRenderer.
  Coupled with the above: the header is gated on pageType !== 'record', so
  fixing label alone would still render nothing.
- field maxLength/minLength: validation already dual-read them, but
  ObjectForm's HTML-attribute pass and TextAreaField read max_length only --
  no browser cap, no character counter for spec-authored metadata.

Browser-verified against the showcase: capability_map (type:'home') now
renders data-page-type="home", max-w-screen-2xl and its title; record pages
unchanged. 625 tests green across the touched packages.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jul 27, 2026 1:58pm

Request Review

@os-zhuang os-zhuang mentioned this pull request Jul 27, 2026
Merged
@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 28.0 KB 350 KB
Entry file index-CpDyLqEb.js —
Status PASS —

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 8.20KB 2.97KB
app-shell (runtime-config.js) 7.42KB 2.32KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 7.57KB 2.97KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 21.70KB 4.21KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.12KB 3.41KB
auth (LoginForm.js) 17.86KB 5.29KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.43KB 2.09KB
auth (SocialSignInButtons.js) 9.60KB 3.89KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 33.74KB 8.53KB
auth (createAuthenticatedFetch.js) 4.37KB 1.69KB
auth (index.js) 1.83KB 0.79KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.86KB 0.85KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 450.91KB 98.17KB
core (index.js) 2.12KB 0.77KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 127.29KB 31.96KB
fields (index.js) 218.37KB 53.54KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.70KB 0.83KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 25.17KB 5.80KB
i18n (useSafeTranslation.js) 2.87KB 1.28KB
layout (index.js) 38.45KB 10.67KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 4.42KB 1.27KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 1.77KB 0.77KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 6.84KB 2.42KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.67KB 1.12KB
permissions (evaluator.js) 4.00KB 1.23KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.55KB 0.71KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 45.37KB 12.48KB
plugin-charts (index.js) 47.20KB 13.35KB
plugin-chatbot (index.js) 179.53KB 42.79KB
plugin-dashboard (index.js) 109.60KB 28.33KB
plugin-designer (index.js) 210.92KB 42.69KB
plugin-detail (index.js) 215.28KB 52.50KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 103.56KB 25.13KB
plugin-gantt (index.js) 162.33KB 39.53KB
plugin-grid (index.js) 178.20KB 46.71KB
plugin-kanban (index.js) 47.82KB 13.18KB
plugin-list (index.js) 98.71KB 23.32KB
plugin-map (index.js) 16.80KB 5.24KB
plugin-markdown (index.js) 13.65KB 4.67KB
plugin-report (index.js) 37.07KB 9.81KB
plugin-timeline (index.js) 25.37KB 7.20KB
plugin-tree (index.js) 8.36KB 2.81KB
plugin-view (index.js) 85.70KB 20.87KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.55KB 0.67KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 3.19KB 1.38KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 18.70KB 6.09KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 1.00KB 0.55KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 2.16KB 0.94KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.77KB 0.41KB
types (disclosure.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 1.86KB 0.91KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.04KB 1.93KB
types (system-fields.js) 2.39KB 1.17KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 0.75KB 0.46KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang merged commit 2f947e4 into main Jul 27, 2026
14 checks passed
@os-zhuang
os-zhuang deleted the fix/naming-drift-page-and-maxlength branch July 27, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: components plugin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@os-zhuang