fix(app-shell,i18n): drop the developer-voiced default form subtitle - #3093
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
Every create/edit record form (console dialog in AppContent and the
full-page RecordFormPage) hardcoded a default description under the
title: 'Add a new {{object}} to your database.' / 'Update details for
{{object}}'. The copy is admin-panel boilerplate leaking into end-user
business apps — end users have no business being told about 'the
database' — and neither call site let a form view override it.
Both call sites stop passing 'description', and the now-unused
'form.createDescription' / 'form.editDescription' keys are removed from
all ten locale bundles ('workspace.createDescription' is unrelated and
stays). i18n tests updated accordingly.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every create/edit record form — the console dialog in
AppContentand the full-pageRecordFormPage— hardcoded a platform default description under the title:The copy is developer-tooling voice leaking into end-user business apps — a scheduling clerk filling in a form has no business being told about "the database". The line carried no information the form title didn't already have, and neither call site let a form view override it.
Changes
description— record forms no longer render a default subtitle.form.createDescription/form.editDescriptionkeys are removed from all ten locale bundles (workspace.createDescriptionis unrelated and stays).@object-ui/app-shell+@object-ui/i18n.Testing
npx vitest run packages/i18n packages/app-shell: 264 files, 2221 tests, all passing.🤖 Generated with Claude Code